Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datatables #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Datatables #10

wants to merge 2 commits into from

Conversation

NightZpy
Copy link

  • Fixed header.
  • Reorder columns.

@Braunson Braunson mentioned this pull request Nov 8, 2017
@Braunson
Copy link

Braunson commented Nov 8, 2017

@NightZpy Can you fix the conflicts. @garygreen once that's done can you merge this?

@garygreen
Copy link
Owner

I was originally not much of a fan of this idea because I think paginating a list of routes is incredibly annoying - flicking through 40 different pages to find the route you want isn't a friendly experience.

Sorting columns could be useful, however I feel that the display order of the routes is extremely important, as routes are matched in order of priority - if we did allow for sorting of columns we should add a "Number" column of some kind, so you can reset the routes back to the order they will actually be matched in.

Finding routes / grepping can easily be done by just CTRL + F in the browser, it's pretty simple already, no?

Overall, I'm not sure adding data tables will add a huge amount of value except increase the complexity of an already simple package. But I'm not adverse to changing my way of thinking on it 😄

@andrey-helldar
Copy link
Contributor

I understand that the question in this thread is very old and, apparently, @garygreen is busy with the main work, so I released my version from the fork as self-contained package.
It's easier to look at a package than to talk about its changes: https://github.com/andrey-helldar/pretty-routes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants