Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add https support, use WiFiClientSecure instead of WiFiClient #5

Merged
merged 1 commit into from Oct 5, 2021
Merged

Add https support, use WiFiClientSecure instead of WiFiClient #5

merged 1 commit into from Oct 5, 2021

Conversation

melizeche
Copy link
Collaborator

Add https support, this approach doesn't verify the TLS Cert but at least the connection is encrypted

@garyservin
Copy link
Owner

LGTM, let me test on my sensor just to confirm it works on my end

garyservin
garyservin approved these changes Oct 5, 2021
View reviewed changes
Copy link
Owner

@garyservin garyservin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my sensor, works fine! Thanks!!

@garyservin garyservin merged commit d54f19c into master Oct 5, 2021
@garyservin garyservin deleted the feature/add_https branch October 5, 2021 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garyservin garyservin garyservin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@melizeche @garyservin