Set allChunks to true for ExtractTextPlugin #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
js62789
force-pushed
the
jsmith/css-all-chunks
branch
from
829145c
to
37cb88d
Compare
|
This seems reasonable to me. |
wallycarvalho
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have our consumer-web project very close to serving page-specific bundles/chunks. The issue we're running into is discussed in webpack-contrib/extract-text-webpack-plugin#456. Chunking CSS doesn't work because errors are thrown when trying to import
style-loader/addStylesandcss-loader/lib/css-base. I tried just adding those files to our vendor array, but it didn't seem to work, so I'm proposing we avoid chunking CSS for now.