Change webpack visualizer #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruv-m-patel
changed the title
|
Related to this here is react documentation that says duplicate/different versions of react in dependencies which can affect how react reference gets resolved: https://reactjs.org/warnings/invalid-hook-call-warning.html#duplicate-react |
djMax
approved these changes
Mar 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across react documentation that suggested ensuring we have same react version in deps when we run
npm ls react.I found out that
webpack-visualizer-pluginused in this repo was using react v0.14.9 and hence I checked the issues. As per maintainer's comment it doesn't look like the package is being maintained actively, and webpack-bundle-analyzer sounds like a better alternative to move forward with which uses latest version of react.