Skip to content

Commit

Permalink
cran resubmission (quotes)
Browse files Browse the repository at this point in the history
  • Loading branch information
gastonbecerra committed Apr 16, 2020
1 parent 0ce4e7a commit 85c3884
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
2 changes: 1 addition & 1 deletion CRAN-RELEASE
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
This package was submitted to CRAN on 2020-04-14.
Once it is accepted, delete this file and tag the release (commit 8de87767c7).
Once it is accepted, delete this file and tag the release (commit 0ce4e7a1e1).
14 changes: 7 additions & 7 deletions DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,16 +1,16 @@
Package: ojsr
Type: Package
Title: Crawler and Scraper for OJS
Title: Crawler and Scraper for Open Journal System ('OJS')
Version: 0.1.0
Authors@R: person("Gaston", "Becerra", email = "gaston.becerra@gmail.com",
role = c("aut", "cre"),
comment = c(ORCID = "0000-0001-9432-8848"))
Description: Crawler for OJS pages and scraper for meta-data from articles.
You can crawl OJS archives, issues, articles, galleys, and search results.
You can scrap articles meta-data from their head tag in html, or from OAI records.
Most of these functions rely on OJS routing conventions
(<https://docs.pkp.sfu.ca/dev/documentation/en/architecture-routes>),
and are most likely to fail on OJS installments with customized routing.
Description: Crawler for 'OJS' pages and scraper for meta-data from articles.
You can crawl 'OJS' archives, issues, articles, galleys, and search results.
You can scrap articles meta-data from their head tag in html,
or from Open Archives Initiative ('OAI') records.
Most of these functions rely on 'OJS' routing conventions
(<https://docs.pkp.sfu.ca/dev/documentation/en/architecture-routes>).
License: GPL-3
Encoding: UTF-8
LazyData: true
Expand Down
8 changes: 8 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
## Resubmission

### 20/04/16

Fixed in DESCRIPTION:
- OJS and OAI acronyms mentioned in undirected single quotes.

AlsO:
- deleted dev comments in test file

### 20/04/14

Fixed in DESCRIPTION:
Expand Down
7 changes: 2 additions & 5 deletions tests/testthat/test_scrapers.R
Original file line number Diff line number Diff line change
@@ -1,5 +1,2 @@
# context("ojs scraper")
# library(ojsr)

# scraping test rely on external sources... not sure how to include them here
# maybe with skip_on_cran()?
context("ojs scraper")
library(ojsr)

0 comments on commit 85c3884

Please sign in to comment.