Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Commit

Permalink
GTNPORTAL-3019 adding href attributes in <a> tags for keyboard access…
Browse files Browse the repository at this point in the history 
…ibility
  • Loading branch information
@lucasponce @bdaw
lucasponce authored and bdaw committed May 15, 2013
1 parent 0be3273 commit 557e006
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 24 deletions.
2 changes: 1 addition & 1 deletion ...oadmin/src/main/webapp/groovy/applicationregistry/webui/component/UIApplicationInfo.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ String applicationDescription = encoder.encode(application.getDescription());
%>
<div class="$uicomponent.id" id="$uicomponent.id">
<div class="UIBreadcumb">
<div class="ControlIcon EditIcon" title="<%=_ctx.appRes("UIApplicationInfo.title.editApplication")%>" onclick="<%= uicomponent.event("EditApplication") %>"><span></span></div>
<a href="javascript:;" title="<%=_ctx.appRes("UIApplicationInfo.title.editApplication")%>" onclick="<%= uicomponent.event("EditApplication") %>"><div class="ControlIcon EditIcon" title="<%=_ctx.appRes("UIApplicationInfo.title.editApplication")%>"><span></span></div></a>
<div class="BreadcumbInfo">
<div class="FL" title="<%= category.getDisplayName(true) %>"><%= categoryDisplayName %></div>
<div class="RightBlackGridArrow16x16Icon"><span></span></div>
Expand Down
16 changes: 8 additions & 8 deletions ...n/src/main/webapp/groovy/applicationregistry/webui/component/UIApplicationOrganizer.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ def selectedApp = uicomponent.getSelectedApplication();
%>
<div class="UIOrganizerManagement" id="$uicomponent.id">
<div class="UIControlbar ClearFix">
<div class="IconControl AddCategoryIcon" onclick="<%= uicomponent.event("AddCategory") %>"><%=_ctx.appRes("UIOrganizer.label.addCategory")%></div>
<div class="IconControl AddCategoryIcon" ><a href="javascript:;" onclick="<%= uicomponent.event("AddCategory") %>"><%=_ctx.appRes("UIOrganizer.label.addCategory")%></a></div>
<% if(uicomponent.isShowImport()) { %>
<div class="IconControl ImportIcon" onclick="<%= uicomponent.event("ImportAllApplications") %>"><%=_ctx.appRes("UIOrganizer.label.autoImport")%></div>
<div class="IconControl ImportIcon"><a href="javascript:;" onclick="<%= uicomponent.event("ImportAllApplications") %>"><%=_ctx.appRes("UIOrganizer.label.autoImport")%></a></div>
<% } %>
</div>

Expand Down Expand Up @@ -43,13 +43,13 @@ def selectedApp = uicomponent.getSelectedApplication();
<div class="TabLeft">
<div class="TabRight">
<div class="TabRepeat ClearFix">
<a class="TabLabel" onclick="<%= uicomponent.event("ShowCategory", cName) %>" title="<%= displayName %>">
<a class="TabLabel" href="javascript:;" onclick="<%= uicomponent.event("ShowCategory", cName) %>" title="<%= displayName %>">
<%= displayName %>
</a>
<% if(isSelected) { %>
<a class="ControlIcon DeleteIcon" title="<%=_ctx.appRes("UIOrganizer.title.deleteCategory")%>" onclick="<%= uicomponent.event("RemoveCategory", "$cName") %>"><span></span></a>
<a class="ControlIcon CreateNewIcon" title="<%=_ctx.appRes("UIOrganizer.title.addApplication")%>" onclick="<%= uicomponent.event("AddApplication") %>"><span></span></a>
<a class="ControlIcon EditIcon" title="<%=_ctx.appRes("UIOrganizer.title.editCategory")%>" onclick="<%= uicomponent.event("EditCategory", "$cName") %>"><span></span></a>
<a class="ControlIcon DeleteIcon" title="<%=_ctx.appRes("UIOrganizer.title.deleteCategory")%>" href="javascript:;" onclick="<%= uicomponent.event("RemoveCategory", "$cName") %>"><span></span></a>
<a class="ControlIcon CreateNewIcon" title="<%=_ctx.appRes("UIOrganizer.title.addApplication")%>" href="javascript:;" onclick="<%= uicomponent.event("AddApplication") %>"><span></span></a>
<a class="ControlIcon EditIcon" title="<%=_ctx.appRes("UIOrganizer.title.editCategory")%>" href="javascript:;" onclick="<%= uicomponent.event("EditCategory", "$cName") %>"><span></span></a>
<% } %>
</div>
</div>
Expand All @@ -69,8 +69,8 @@ def selectedApp = uicomponent.getSelectedApplication();
String displayApplicationName = (applicationLabel.length() <= 30) ? applicationLabel : applicationLabel.substring(0, 27)+"...";
displayApplicationName = encoder.encode(displayApplicationName);
%>
<a onclick="<%= uicomponent.event("SelectApplication", "$appName") %>" class="ItemLabel" title="<%= application.getDisplayName() %>"><%= displayApplicationName %><span></span></a>
<a class="ControlIcon DeletePortalIcon" title="<%=_ctx.appRes("UIOrganizer.title.deleteApplication")%>" onclick="<%= uicomponent.event("RemoveApplication", appName) %>"><span></span></a>
<a href="javascript:;" onclick="<%= uicomponent.event("SelectApplication", "$appName") %>" class="ItemLabel" title="<%= application.getDisplayName() %>"><%= displayApplicationName %><span></span></a>
<a class="ControlIcon DeletePortalIcon" title="<%=_ctx.appRes("UIOrganizer.title.deleteApplication")%>" href="javascript:;" onclick="<%= uicomponent.event("RemoveApplication", appName) %>"><span></span></a>
</div>
<% } %>
</div>
Expand Down
6 changes: 3 additions & 3 deletions ...main/webapp/groovy/applicationregistry/webui/component/UIApplicationRegistryPortlet.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -21,22 +21,22 @@
cssClass = "ItemButton";
if(uicomponent.getChild(0).isRendered()) cssClass = "SelectItemButton";
%>
<a onclick="<%=uicomponent.event("ViewChild", "UIApplicationOrganizer")%>" class="$cssClass ItemButton OrganizeIcon">
<a href="javascript:;" onclick="<%=uicomponent.event("ViewChild", "UIApplicationOrganizer")%>" class="$cssClass ItemButton OrganizeIcon">
<%=_ctx.appRes("UIToolbar.label.organize")%>
</a>
<%
cssClass = "ItemButton";
if(uicomponent.getChild(2).isRendered()) cssClass = "ItemButton SelectItemButton";
%>
<a onclick="<%=uicomponent.event("ViewChild", "UIGadgetManagement")%>" class="$cssClass ItemButton GadgetIcon" style="float: <%= isLT? "right" : "left" %>">
<a href="javascript:;" onclick="<%=uicomponent.event("ViewChild", "UIGadgetManagement")%>" class="$cssClass ItemButton GadgetIcon" style="float: <%= isLT? "right" : "left" %>">
<%=_ctx.appRes("UIToolbar.label.gadget")%>
</a>
<div class="HorizontalSeparator" style="float: <%= isLT? "right" : "left" %>"><span></span></div>
<%
cssClass = "ItemButton";
if(uicomponent.getChild(1).isRendered()) cssClass = "ItemButton SelectItemButton";
%>
<a onclick="<%=uicomponent.event("ViewChild", "UIPortletManagement")%>" class="$cssClass ItemButton PorletIcon" style="float: <%= isLT? "right" : "left" %>">
<a href="javascript:;" onclick="<%=uicomponent.event("ViewChild", "UIPortletManagement")%>" class="$cssClass ItemButton PorletIcon" style="float: <%= isLT? "right" : "left" %>">
<%=_ctx.appRes("UIToolbar.label.portlet")%>
</a>
</div>
Expand Down
12 changes: 6 additions & 6 deletions ...et/exoadmin/src/main/webapp/groovy/applicationregistry/webui/component/UIGadgetInfo.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -31,39 +31,39 @@
<div class="ApplicationContent">
<table class="TitleBarApplication" summary="Gadget Display Name">
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.name")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.name")%></td>
<td class="RightLabel" title=" <%= gadget.getName() %> "><%= gadget.getName() %></td>
</tr>
</table>
<table summary="Gadget Description">
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.description")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.description")%></td>
<td class="RightLabel" title=" <%= gadget.getDescription() %> "><%= gadget.getDescription() %></td>
</tr>
</table>
<table summary="Gadget URLs">
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.viewUrl")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.viewUrl")%></td>
<td class="RightLabel" title=" <%=viewURL %> "><a href="<%=viewURL %>" target="_blank">$viewURL</a></td>
</tr>
<% if(gadget.isLocal()) {%>
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.editUrl")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.editUrl")%></td>
<td class="RightLabel"><a href="<%=editURL %>" target="_blank">$editURL</a></td>
</tr>
<% } %>
</table>
<table summary="Gadget Reference">
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.reference")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.reference")%></td>
<td class="RightLabel">
<a href="<%=refURL %>" target="_blank">$refURL</a>
</td>
</tr>
</table>
<table summary="Gadget Categories">
<tr>
<td class="LeftLabel"><%=_ctx.appRes("UIGadgetInfo.label.categories")%></td>
<td class="LeftLabel" scope="row"><%=_ctx.appRes("UIGadgetInfo.label.categories")%></td>
<td class="RightLabel"><%= encoder.encode(categoryNames) %>
<% if (categoryNames.equals("")) { %>
<%=_ctx.appRes("UIGadgetInfo.label.categories.guide")%><br/>
Expand Down
8 changes: 4 additions & 4 deletions ...admin/src/main/webapp/groovy/applicationregistry/webui/component/UIGadgetManagement.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@
%>
<div class="UIGadgetManagement" id="$uicomponent.id">
<div class="UIControlbar ClearFix">
<div class="IconControl AddNewIcon" onclick="<%= uicomponent.event("AddRemoteGadget") %>"><%=_ctx.appRes("UIGadgetManagement.label.addRemote")%></div>
<div class="IconControl CreateNewIcon" onclick="<%= uicomponent.event("AddLocalGadget") %>"><%=_ctx.appRes("UIGadgetManagement.label.createNew")%></div>
<a href="javascript:;" onclick="<%= uicomponent.event("AddRemoteGadget") %>"><div class="IconControl AddNewIcon" ><%=_ctx.appRes("UIGadgetManagement.label.addRemote")%></div></a>
<a href="javascript:;" onclick="<%= uicomponent.event("AddLocalGadget") %>"><div class="IconControl CreateNewIcon" ><%=_ctx.appRes("UIGadgetManagement.label.createNew")%></div></a>
</div>

<div class="AppRegistryContainer ClearFix">
Expand All @@ -24,8 +24,8 @@
%>
<div class="$cssItem ItemContent ClearFix">
<% def gadgetLabel = gadget.getTitle() %>
<a onclick="<%= uicomponent.event("SelectGadget", gadget.getName()) %>" class="TabLabel $gadgetType" title="<%= gadget.getTitle() %>"><%= (gadgetLabel.length() <= 31) ? gadgetLabel : gadgetLabel.substring(0, 28)+"..." %></a>
<a title="<%=_ctx.appRes("UIGadgetManagement.title.deleteGadget")%>" class="ControlIcon DeletePortalIcon" onclick="<%= uicomponent.event("RemoveGadget", gadget.getName()) %>"><span></span></a>
<a href="javascript:;" onclick="<%= uicomponent.event("SelectGadget", gadget.getName()) %>" class="TabLabel $gadgetType" title="<%= gadget.getTitle() %>"><%= (gadgetLabel.length() <= 31) ? gadgetLabel : gadgetLabel.substring(0, 28)+"..." %></a>
<a title="<%=_ctx.appRes("UIGadgetManagement.title.deleteGadget")%>" class="ControlIcon DeletePortalIcon" href="javascript:;" onclick="<%= uicomponent.event("RemoveGadget", gadget.getName()) %>"><span></span></a>
</div>
<% } %>
</div>
Expand Down
4 changes: 2 additions & 2 deletions ...dmin/src/main/webapp/groovy/applicationregistry/webui/component/UIPortletManagement.gtmpl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
<div class="CategoryContent">
<% for(type in portletTypes) {%>
<div class="BoxContent">
<div class="TitleCategory" onclick="<%= uicomponent.event("SelectPortletType", type) %>"><%=_ctx.appRes("UIPortletManagement.title." + type)%></div>
<div class="TitleCategory"><a href="javascript:;" onclick="<%= uicomponent.event("SelectPortletType", type) %>"><%=_ctx.appRes("UIPortletManagement.title." + type)%></a></div>
<% if(type.equals(selectedType)) {%>
<div class="ListContent">

Expand All @@ -34,7 +34,7 @@
isSelected = true;
} else cssClass = "Item";
%>
<a class="$cssClass" onclick="<%= uicomponent.event("SelectPortlet", portlet.getId()) %>"><%= portlet.getDisplayName() %></a>
<a class="$cssClass" href="javascript:;" onclick="<%= uicomponent.event("SelectPortlet", portlet.getId()) %>"><%= portlet.getDisplayName() %></a>
<% } %>
</div>

Expand Down

0 comments on commit 557e006

Please sign in to comment.