GTNPORTAL-3082 Facebook bugs with test users. Test users will be link…

…ed to GateIn by FB id
gatein · May 30, 2013 · bab22d7 · bab22d7
1 parent 6ac7d1a
commit bab22d7
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/...nt/web/oauth-common/src/main/java/org/gatein/security/oauth/social/FacebookProcessor.java b/...nt/web/oauth-common/src/main/java/org/gatein/security/oauth/social/FacebookProcessor.java
@@ -212,7 +212,7 @@ protected FacebookPrincipal parseResponse(String httpResponse) throws JSONExcept
 
                 FacebookPrincipal facebookPrincipal = new FacebookPrincipal();
                 facebookPrincipal.setAccessToken(accessToken);
-                facebookPrincipal.setId(jsonObject.optString("id"));
+                facebookPrincipal.setId(jsonObject.getString("id"));
                 facebookPrincipal.setName(jsonObject.optString("name"));
                 facebookPrincipal.setUsername(jsonObject.optString("username"));
                 facebookPrincipal.setFirstName(jsonObject.optString("first_name"));
@@ -222,6 +222,12 @@ protected FacebookPrincipal parseResponse(String httpResponse) throws JSONExcept
                 facebookPrincipal.setLocale(jsonObject.optString("locale"));
                 facebookPrincipal.setEmail(jsonObject.optString("email"));
                 facebookPrincipal.setJsonObject(jsonObject);
+
+                // This could happen with Facebook testing users
+                if (facebookPrincipal.getUsername() == null || facebookPrincipal.getUsername().length() == 0) {
+                    facebookPrincipal.setUsername(facebookPrincipal.getId());
+                }
+
                 return facebookPrincipal;
             }