Skip to content
This repository has been archived by the owner on Apr 8, 2019. It is now read-only.

Commit

Permalink
GTNPORTAL-2957: extracted shindig-related dependencies into a module …
Browse files Browse the repository at this point in the history
…to prevent issues with ehcache and jbossws-cxf with wsrp and wss :(

- Created org.gatein.shindig module
- Created org.json module used both by org.gatein.lib and org.gatein.shindig
- Cleaned-up org.gatein.lib module
- Added MANIFEST dependencies on org.gatein.shindig module in eXoGadgetServer war
  • Loading branch information
metacosm authored and mstruk committed May 6, 2013
1 parent b998162 commit f1af8fa
Show file tree
Hide file tree
Showing 5 changed files with 153 additions and 22 deletions.
13 changes: 13 additions & 0 deletions gadgets/server/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,19 @@

<build>
<finalName>eXoGadgetServer</finalName>
<plugins>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-war-plugin</artifactId>
<configuration>
<archive>
<manifestEntries>
<Dependencies>org.gatein.shindig</Dependencies>
</manifestEntries>
</archive>
</configuration>
</plugin>
</plugins>
</build>

<dependencies>
Expand Down
78 changes: 57 additions & 21 deletions packaging/jboss-as7/modules/build.xml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,42 @@
~ +++++++ KEEP THIS LIST ALPHABETICAL BY MODULE NAME! +++++++
~ +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
-->
<module-def name="com.google.guava" slot="gatein">
<maven-resource group="com.google.guava" artifact="guava"/>
</module-def>

<module-def name="org.gatein.shindig">
<maven-resource group="net.sf.ehcache" artifact="ehcache-core"/>
<maven-resource group="com.google.inject" artifact="guice"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-jmx"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-multibindings"/>
<maven-resource group="aopalliance" artifact="aopalliance"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-common"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-features"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-gadgets"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-social-api"/>
<maven-resource group="caja" artifact="caja"/>
<maven-resource group="caja" artifact="json_simple"/>
<maven-resource group="rome" artifact="rome"/>
<maven-resource group="rome" artifact="modules"/>
<maven-resource group="com.ibm.icu" artifact="icu4j"/>
<maven-resource group="net.sourceforge.nekohtml" artifact="nekohtml"/>
<maven-resource group="commons-digester" artifact="commons-digester"/>

<!-- this dependency present in gadget-server pom hasn't showed up in testing, nor was it included in gatein.lib so not sure what to do with it -->
<!--
<dependency>
<groupId>nu.validator.htmlparser</groupId>
<artifactId>htmlparser</artifactId>
<scope>provided</scope>
</dependency>
-->
</module-def>

<module-def name="org.json">
<maven-resource group="org.json" artifact="json"/>
</module-def>

<module-def name="org.gatein">
<maven-resource group="org.gatein.portal" artifact="jboss-as7-integration-extension"/>
</module-def>
Expand All @@ -76,18 +112,14 @@

<module-def name="org.gatein.lib">
<!-- maven-resource group="javax.activation" artifact="activation" / -->
<maven-resource group="aopalliance" artifact="aopalliance"/>
<maven-resource group="bouncycastle" artifact="bcmail-jdk14"/>
<maven-resource group="bouncycastle" artifact="bcprov-jdk14"/>
<maven-resource group="caja" artifact="caja"/>
<maven-resource group="com.google.javascript" artifact="closure-compiler"/>
<maven-resource group="commons-chain" artifact="commons-chain"/>
<!--<maven-resource group="commons-codec" artifact="commons-codec" />-->
<maven-resource group="commons-dbcp" artifact="commons-dbcp"/>
<maven-resource group="commons-digester" artifact="commons-digester"/>
<maven-resource group="commons-httpclient" artifact="commons-httpclient"/>
<maven-resource group="oswego-concurrent" artifact="concurrent"/>
<maven-resource group="net.sf.ehcache" artifact="ehcache-core"/>
<maven-resource group="org.ccil.cowan.tagsoup" artifact="tagsoup"/>
<maven-resource group="org.exoplatform.core" artifact="exo.core.component.database"/>
<maven-resource group="org.exoplatform.core" artifact="exo.core.component.document"/>
Expand Down Expand Up @@ -144,12 +176,8 @@
<maven-resource group="org.gatein.management" artifact="gatein-management-rest"/>
<maven-resource group="org.gatein.web" artifact="redirect"/>
<maven-resource group="org.codehaus.groovy" artifact="groovy-all"/>
<maven-resource group="com.google.inject" artifact="guice"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-jmx"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-multibindings"/>
<maven-resource group="howl" artifact="howl-logger"/>
<maven-resource group="org.htmlparser" artifact="htmlparser"/>
<maven-resource group="com.ibm.icu" artifact="icu4j"/>
<maven-resource group="org.infinispan" artifact="infinispan-tree"/>
<maven-resource group="org.jboss.cache" artifact="jbosscache-core"/>
<!--maven-resource group="org.jboss.jbossts" artifact="jbossjts" /-->
Expand All @@ -158,8 +186,6 @@
<maven-resource group="org.jibx" artifact="jibx-run"/>
<maven-resource group="rhino" artifact="js"/>
<maven-resource group="org.jsecurity" artifact="jsecurity"/>
<maven-resource group="caja" artifact="json_simple"/>
<maven-resource group="org.json" artifact="json"/>
<maven-resource group="de.odysseus.juel" artifact="juel-impl"/>
<maven-resource group="org.apache.lucene" artifact="lucene-core"/>
<maven-resource group="org.apache.lucene" artifact="lucene-memory"/>
Expand All @@ -168,7 +194,6 @@
<maven-resource group="org.gatein.mop" artifact="mop-api"/>
<maven-resource group="org.gatein.mop" artifact="mop-core"/>
<maven-resource group="org.gatein.mop" artifact="mop-spi"/>
<maven-resource group="net.sourceforge.nekohtml" artifact="nekohtml"/>
<maven-resource group="net.oauth.core" artifact="oauth"/>
<maven-resource group="org.apache.pdfbox" artifact="pdfbox"/>
<maven-resource group="org.picketlink.idm" artifact="picketlink-idm-api"/>
Expand All @@ -181,13 +206,7 @@
<maven-resource group="org.apache.poi" artifact="poi"/>
<maven-resource group="org.apache.poi" artifact="poi-ooxml"/>
<maven-resource group="org.apache.poi" artifact="poi-scratchpad"/>
<maven-resource group="rome" artifact="rome"/>
<maven-resource group="rome" artifact="modules"/>
<maven-resource group="org.apache.sanselan" artifact="sanselan"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-common"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-features"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-gadgets"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-social-api"/>
<maven-resource group="org.gatein.captcha" artifact="simplecaptcha"/>
<maven-resource group="org.apache.tika" artifact="tika-core"/>
<maven-resource group="org.apache.tika" artifact="tika-parsers"/>
Expand All @@ -197,6 +216,27 @@
<maven-resource group="org.apache.xmlbeans" artifact="xmlbeans"/>
<maven-resource group="com.thoughtworks.xstream" artifact="xstream"/>
<maven-resource group="org.gatein.cdi" artifact="gatein-cdi-injection"/>

<!-- modules that were used by shindig, commented out for reference -->
<!--
<maven-resource group="aopalliance" artifact="aopalliance"/>
<maven-resource group="caja" artifact="caja"/>
<maven-resource group="commons-digester" artifact="commons-digester"/>
<maven-resource group="net.sf.ehcache" artifact="ehcache-core"/>
<maven-resource group="com.google.inject" artifact="guice"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-jmx"/>
<maven-resource group="com.google.inject.extensions" artifact="guice-multibindings"/>
<maven-resource group="com.ibm.icu" artifact="icu4j"/>
<maven-resource group="caja" artifact="json_simple"/>
<maven-resource group="org.json" artifact="json"/>
<maven-resource group="net.sourceforge.nekohtml" artifact="nekohtml"/>
<maven-resource group="rome" artifact="rome"/>
<maven-resource group="rome" artifact="modules"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-common"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-features"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-gadgets"/>
<maven-resource group="org.gatein.shindig" artifact="shindig-social-api"/>
-->
</module-def>

<module-def name="org.gatein.wci">
Expand Down Expand Up @@ -315,10 +355,6 @@
<module-def name="org.xmlpull" slot="main">
<maven-resource group="xpp3" artifact="xpp3"/>
</module-def>

<module-def name="com.google.guava" slot="gatein">
<maven-resource group="com.google.guava" artifact="guava"/>
</module-def>
</target>

<target name="clean-target">
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,14 @@
<module name="org.apache.httpcomponents"/>
<module name="org.gatein.naming" export="true"/>
<module name="org.gatein.pc"/>
<module name="org.gatein.shindig"/>
<module name="org.gatein.wci" export="true"/>
<module name="org.hibernate"/>
<module name="org.infinispan"/>
<module name="org.javassist"/>
<module name="org.joda.time"/>
<module name="org.jdom"/>
<module name="org.json" export="true"/>
<module name="org.slf4j"/>
<module name="org.staxnav"/>
<module name="com.google.guava" slot="gatein" export="true"/>
Expand All @@ -76,7 +78,6 @@
<module name="com.h2database.h2"/>
<module name="org.jboss.common-core"/>

<module name="javax.inject.api"/>
<module name="javax.enterprise.api"/>
<module name="javax.mail.api"/>

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,49 @@
<?xml version="1.0" encoding="UTF-8"?>

<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2010, Red Hat, Inc., and individual contributors
~ as indicated by the @author tags. See the copyright.txt file in the
~ distribution for a full listing of individual contributors.
~
~ This is free software; you can redistribute it and/or modify it
~ under the terms of the GNU Lesser General Public License as
~ published by the Free Software Foundation; either version 2.1 of
~ the License, or (at your option) any later version.
~
~ This software is distributed in the hope that it will be useful,
~ but WITHOUT ANY WARRANTY; without even the implied warranty of
~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
~ Lesser General Public License for more details.
~
~ You should have received a copy of the GNU Lesser General Public
~ License along with this software; if not, write to the Free
~ Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
~ 02110-1301 USA, or see the FSF site: http://www.fsf.org.
-->

<module xmlns="urn:jboss:module:1.1" name="org.gatein.shindig">
<resources>
<!-- Insert resources here -->
</resources>

<dependencies>
<module name="javax.inject.api"/>
<module name="javax.servlet.api"/>
<module name="javax.api"/>
<module name="javax.transaction.api"/>
<module name="javax.el.api"/>
<module name="org.json"/>
<module name="org.joda.time"/>
<module name="org.slf4j"/>
<module name="com.google.guava" slot="gatein"/>
<module name="org.apache.commons.lang"/>
<module name="org.apache.commons.codec"/>
<module name="org.apache.httpcomponents"/>
<module name="org.apache.xerces"/>
<module name="org.gatein.lib"/>
<module name="org.apache.commons.io"/>
<module name="org.apache.commons-fileupload"/>
<module name="org.jaxen"/>
</dependencies>
</module>
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
<?xml version="1.0" encoding="UTF-8"?>

<!--
~ JBoss, Home of Professional Open Source.
~ Copyright 2010, Red Hat, Inc., and individual contributors
~ as indicated by the @author tags. See the copyright.txt file in the
~ distribution for a full listing of individual contributors.
~
~ This is free software; you can redistribute it and/or modify it
~ under the terms of the GNU Lesser General Public License as
~ published by the Free Software Foundation; either version 2.1 of
~ the License, or (at your option) any later version.
~
~ This software is distributed in the hope that it will be useful,
~ but WITHOUT ANY WARRANTY; without even the implied warranty of
~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
~ Lesser General Public License for more details.
~
~ You should have received a copy of the GNU Lesser General Public
~ License along with this software; if not, write to the Free
~ Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
~ 02110-1301 USA, or see the FSF site: http://www.fsf.org.
-->

<module xmlns="urn:jboss:module:1.1" name="org.json">
<resources>
<!-- Insert resources here -->
</resources>

<dependencies>
</dependencies>
</module>

0 comments on commit f1af8fa

Please sign in to comment.