GTNPORTAL-2496 (revisited) Invalid encoding in gadget source not handled properly

[ppalaga]

No description provided.

[vietj]

would you mind to reuse an existing XML exception and avoid to introduce XMLDeclarationParseException ?

thanks

Julien.

[ppalaga]

Thank you for your feed back, Julien.

which existing XML exception do you exactly mean? org.apache.shindig.common.xml.XmlException?

[vietj]

this exception tht I can see in the patch : XMLDeclarationParser. XMLDeclarationParseException

[vietj]

also did you check that XML declaration can be parsed by a regular expression ?

[ppalaga]

Julien, I hope I understand your original request correctly. Let me paraphrase you: You want me to replace XMLDeclarationParseException with something else, namely an "existing XML exception".
So my question was and still is: What do you mean with "existing XML exception"? What should I replace XMLDeclarationParseException with?
To figure out, what you mean, I was looking for a class named "XmlException" and I have found org.apache.shindig.common.xml.XmlException. Did you mean this one?

also did you check that XML declaration can be parsed by a regular expression ?

No, I did not. But now, after considering it, no, I regard it as unpractical and unreliable (I can tell you why If you are interested).

[vietj]

context mismatch sorry : I meant SAXException that seems more appropriate (even though you are not doing SAX).

for regex : I trust your words. I was just asking if.

[ppalaga]

OK, be it SAXException.
Cancelling to replace XMLDeclarationParseException with SAXException.