Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Gradle UP-TO-DATE check annotations to support Gradle 7 #32

Merged
merged 3 commits into from
Apr 15, 2021
Merged

Add missing Gradle UP-TO-DATE check annotations to support Gradle 7 #32

merged 3 commits into from
Apr 15, 2021

Conversation

AndreasTu
Copy link
Contributor

@AndreasTu AndreasTu commented Apr 15, 2021

Since Gradle 7 Tasks with getters/properties throw errors if they are not properly annotated.

This fixes gatling/gatling/issues/4068

…close #4068

Since Gradle 7 Tasks with getters/properties throw errors if they are not properly annotated.
@Isammoc
Copy link
Member

Isammoc commented Apr 15, 2021

Thanks for this PR! ❤️
Can you add the corresponding tests (ensure that gradle 7 executes correctly).

I guess that should be there GradleCompatibilitySpec.groovy#L36
But I didn't check if other places need to be added.

@slandelle
Copy link
Member

Also, once everything is fixed, could you please sign our CLA?

@AndreasTu
Copy link
Contributor Author

@Isammoc I have added Gradle 7 to the test list.
@slandelle signed

Thanks for the fast feedback!

@Isammoc Isammoc merged commit a86f08f into gatling:master Apr 15, 2021
@Isammoc
Copy link
Member

Isammoc commented Apr 15, 2021

This modification will be part of our next release, when gatling 3.5.2 will be out. (This plugin version currently aligns with the gatling version)

@AndreasTu AndreasTu deleted the Issue_4068 branch April 15, 2021 11:34
@jonatan-ivanov
Copy link

@Isammoc Do you happen to have any ETA for 3.5.2? I'm asking because the issue blocks users of the plugins in two things:

  1. Upgrading to Gradle 7.0
  2. Upgrading to Java 16 (Gradle 6.x does not support Java 16 so users need to upgrade to 7.0)

@slandelle
Copy link
Member

No ETA yet. There are some HTTP/2 issues we want to fix first. Within 1 month max.

@jonatan-ivanov
Copy link

jonatan-ivanov commented May 9, 2021

@slandelle Do you happen to have any ETA for releasing this fix so that users can use Java 16 and Gradle 7.0?

@slandelle
Copy link
Member

The week after next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants