Skip to content

Commit

Permalink
Enforce disableClassPathURLCheck when using default JVM args, close g…
Browse files Browse the repository at this point in the history
…atling/gatling#3677

Modification:

Current workaround is only used when providing custom args.

Modification:

Always add disableClassPathURLCheck

Result:

Should work with buggy Debian stable JDK8 package
  • Loading branch information
slandelle committed Feb 20, 2019
1 parent 3b01b84 commit 06b6605
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions src/main/java/io/gatling/mojo/GatlingMojo.java
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,6 @@
import static io.gatling.mojo.MojoConstants.*;
import static java.nio.file.StandardCopyOption.COPY_ATTRIBUTES;
import static java.nio.file.StandardCopyOption.REPLACE_EXISTING;
import static java.util.Arrays.asList;

/**
* Mojo to execute Gatling.
Expand Down Expand Up @@ -341,7 +340,7 @@ private List<String> compilerJvmArgs() {
return computeArgs(compilerJvmArgs, COMPILER_JVM_ARGS, overrideCompilerJvmArgs);
}

private List<String> computeArgs(List<String> custom, List<String> defaults, boolean override) {
private List<String> computeArgs0(List<String> custom, List<String> defaults, boolean override) {
if (custom.isEmpty()) {
return defaults;
}
Expand All @@ -350,8 +349,11 @@ private List<String> computeArgs(List<String> custom, List<String> defaults, boo
merged.addAll(defaults);
return merged;
}
return custom;
}

List<String> result = new ArrayList<>(custom);
private List<String> computeArgs(List<String> custom, List<String> defaults, boolean override) {
List<String> result = new ArrayList<>(computeArgs0(custom, defaults, override));
// force disable disableClassPathURLCheck because Debian messed up and takes forever to fix, see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=911925
result.add("-Djdk.net.URLClassPath.disableClassPathURLCheck=true");
return result;
Expand Down

0 comments on commit 06b6605

Please sign in to comment.