Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses mute option by default with -s option #2472

Closed
rodo opened this issue Dec 30, 2014 · 8 comments
Closed

Uses mute option by default with -s option #2472

rodo opened this issue Dec 30, 2014 · 8 comments
Assignees
Milestone

Comments

@rodo
Copy link

rodo commented Dec 30, 2014

When migrating from 2.0.1 to 2.1.2 I discover than we must uses the mute option to keep same behaviour. We have hundreds of jobs configure to run under jenkins, and we have to change and add mute option, was it more logical to be mute by default when using -s option ?

@pdalpra
Copy link
Contributor

pdalpra commented Dec 30, 2014

Well, to be honest, I don't think that muting by default when selecting a single simulation was a good idea to begin with : you couldn't choose the simulation ID nor set the description, even if you wanted to.
Now, the choice is yours.

What do you use to run Gatling ?
If you are using the bundle, you could customize gatling.sh to add the -s once and for all there.

@rodo
Copy link
Author

rodo commented Dec 30, 2014

We use Gatling with Jenkins, and effectively I hacked gatling.sh, but I'm not comfortable with the idea to hack Gatling on each upgrade, mainly after see all history disappeared because of stat file format changes. We previously use Tsung to perform stress test, Gatling is new and we hope to find it as usuable as Tsung, may be we have to wait for some release to find stability on upgrades.
Thanks

@pdalpra
Copy link
Contributor

pdalpra commented Dec 30, 2014

I would not call that 'hacking' honestly. You're simply customizing it.
What would you suggest then ? That we revert to muting by default and add yet another option to un-mute ?
Please also note that the bundle is not the only way to run Gatling, and almost all of them would not require modifications on every release.

@slandelle
Copy link
Member

@rodo Instead of editing gatling.sh, you could write a wrapper script that would pass the -m option.

@pdalpra The more I think of it, the less I see a use case for forcing the simulation, yet wanting to be able to run in interactive mode. I'd tend to agree with @rodo on this one.

@pdalpra
Copy link
Contributor

pdalpra commented Dec 30, 2014

Now that I think of it, as long as we support setting the simulation description through CLI option , it could be okay to force mute mode.

@slandelle
Copy link
Member

Yeah. IMO, we want an interactive, and a non-interactive modes.

@slandelle slandelle modified the milestones: 2.0.4, 2.1.3 Dec 30, 2014
@rodo
Copy link
Author

rodo commented Dec 30, 2014

@pdalpra I suggest to keep same behaviour on 2.1.X series than on 2.0.X, when using -s option the mute should be activate by default, an unmute option is a good idea. But as I'm a relatively new user (less than 3 major release :) maybe I missed something.

@slandelle I thought about the wrapper, but my first goal was to not re-configure all my jenkins jobs, so I prefered to hack gatling.sh FYI here how I launch gatling with Jenkins in build Execute shell

#!/bin/bash
${GATLING_HOME}/bin/gatling.sh -df ${WORKSPACE}/APP/datas -rf ${WORKSPACE} -sf ${WORKSPACE} -s ${JOB_NAME}

@rodo
Copy link
Author

rodo commented Dec 31, 2014

Thanks a lot for this patch and congrats for this great tool, inferHtmlResources is real big plus that I loved to add to Tsung one day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants