Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle plugin: Rewrite in kotlin #4357

Closed
Isammoc opened this issue Dec 2, 2022 · 5 comments
Closed

Gradle plugin: Rewrite in kotlin #4357

Isammoc opened this issue Dec 2, 2022 · 5 comments
Assignees
Labels
Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin Type - Chore Type - Declined

Comments

@Isammoc
Copy link
Member

Isammoc commented Dec 2, 2022

As kotlin is now the standard for plugin for gradle, we should rewrite our plugin.

Pros:

Cons:

  • we don't know kotlin either
  • will have to dig in gradle documentation
  • time consuming

Requirements:

  • Current user groovy gradle configuration should still work (except for the plugin version itself, obviously)
@Isammoc Isammoc added Type - Chore Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin labels Dec 2, 2022
@Isammoc
Copy link
Member Author

Isammoc commented Dec 2, 2022

I personally am in favor of a complete rewrite to follow the best practice of kotlin plugin for gradle. (ie, I don't advise to translate from our current groovy implementation)

@slandelle
Copy link
Member

If we decide to go this way, it's paramount that the existing groovy configuration keeps on working, or at least that the change is minimal.

@Isammoc
Copy link
Member Author

Isammoc commented Dec 2, 2022

If we decide to go this way, it's paramount that the existing groovy configuration keeps on working, or at least that the change is minimal.

Agree! Perhaps avoid to hard set the gatling version but let the user decide? (as in maven plugin?)

@slandelle
Copy link
Member

Perhaps avoid to hard set the gatling version

It's not hard set, it's a default value.

mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue May 31, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue May 31, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue May 31, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue May 31, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue May 31, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue Jun 1, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue Jun 1, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue Jul 3, 2023
mackristof added a commit to gatling/gatling-gradle-plugin that referenced this issue Jul 3, 2023
@slandelle
Copy link
Member

Closing as there's no plan for this any time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Module - Gradle Plugin https://github.com/gatling/gatling-gradle-plugin Type - Chore Type - Declined
Development

No branches or pull requests

3 participants