Make FileDataReader support varying length ACTION records (#542)

[nremond]

I'm not sure I understood correctly the request as I don't see why we should remove the pattern matching ... tell me if I missed something ?

[slandelle]

Regarding pattern matching, you were smarter than me, I hadn't thought of this solution. I'll just check the memory footprint.

Regarding the #543, the idea was to have FileDataReader collect all the files in the runId directory. I'll accept your request and revert back some changes.

Thanks,

Steph

[nremond]

My idea about #543 was to have a two classes :
RunDataReader(runId)
FileDataReader(filePath)

By splitting, it's also easier to unit test.

[slandelle]

We could have a composite design, but I'm not ready to break the DataReader
signature as we might have other implementation that don't read from files,
but from other sources, such as a database.

2012/6/8 Nicolas Rémond <
reply@reply.github.com

My idea about #543 was to have a two classes :
RunDataReader(runId)
FileDataReader(filePath)

By splitting, it's also easier to unit test.

---

Reply to this email directly or view it on GitHub:
#550 (comment)

[nremond]

I get it. Are you on it?
I could do the modification right now

[slandelle]

Yep, I'm on it.
Sorry if I stole your toy, I just wanted to finish this quickly so that
Stephen Kuesly can get a chance to work on #446 this week-end, and I can go
and get some sleep (it's been one hell of a week...).

I'll be thinking of more funny stuff you could play with.

Thanks for your help, it's very much appreciated.

Steph

2012/6/8 Nicolas Rémond <
reply@reply.github.com

I get it. Are you on it?
I could do the modification right now

---

Reply to this email directly or view it on GitHub:
#550 (comment)

[skuenzli]

Nice -- thank you for the new matching and tests.