Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reports: Add dark mode #4479

Closed
wants to merge 2 commits into from
Closed

Conversation

micheljung
Copy link
Contributor

First draft, you might want to improve some things, like:

  • Replace PNG icons like "sortable", "roue" and "temps" with an SVG to allow
    styling
  • Revise "Try Gating Enterprise"

Tested on Google Chrome. The setting was stored even when opening another
report with a different path.

Fixes GH-4281

image

First draft, you might want to improve some things, like:

* Replace PNG icons like "sortable", "roue" and "temps" with an SVG to allow
  styling
* Revise "Try Gating Enterprise"

Tested on Google Chrome. The setting was stored even when opening another
report with a different path.

Fixes gatlingGH-4281
@slandelle
Copy link
Member

slandelle commented Nov 23, 2023

@micheljung Looks great, thanks!
@gpoulet Could you please review?

@slandelle
Copy link
Member

@micheljung Could you please sign our CLA?

Copy link
Contributor

@gpoulet gpoulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you 👍

@micheljung
Copy link
Contributor Author

@slandelle signed

@slandelle
Copy link
Member

cherry-picked

Thanks a lot!

@slandelle slandelle closed this Nov 24, 2023
@micheljung micheljung deleted the gh-4281-dark-mode branch November 27, 2023 19:53
@slandelle slandelle changed the title Add dark mode Reports: Add dark mode Dec 14, 2023
@slandelle slandelle added this to the 3.10.0 milestone Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Reports: Dark Theme
3 participants