perf: optimize the way to obtain the styles #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzbian
commented
Apr 29, 2023
fzbian
commented
- getStyle() function was made more efficient by using a dictionary to look up the ANSI codes.
- uncolor()
- function was made more efficient by using a single loop to iterate over the styles and the text.
- function was made more informative by printing a warning if any styles are not found.
- getStyle() function was made more efficient by using a dictionary to look up the ANSI codes. - uncolor() - function was made more efficient by using a single loop to iterate over the styles and the text. - function was made more informative by printing a warning if any styles are not found.
|
Thanks for the PR, I don't know too much about Python. Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.