Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: translate glossary #121

Merged
merged 7 commits into from Jan 26, 2020
Merged

docs: translate glossary #121

merged 7 commits into from Jan 26, 2020

Conversation

Naturalclar
Copy link
Contributor

@Naturalclar Naturalclar commented Jan 23, 2020 •
edited

概要

glossary の翻訳です。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました。
  • 文章全体を最初から読み直して不自然な箇所が無いことを確認しました。
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数に足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

補足

Ref: #1

@gatsbybot gatsbybot mentioned this pull request Jan 23, 2020
Open
@Naturalclar Naturalclar marked this pull request as ready for review January 26, 2020 11:15
@Naturalclar Naturalclar added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: WIP Work in progress labels Jan 26, 2020
@Naturalclar Naturalclar changed the title [WIP] docs: translate glossary docs: translate glossary Jan 26, 2020
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
smorimoto
smorimoto reviewed Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
@smorimoto
Copy link
Contributor

質は安定の高さだったので細かいところだけ直せばすぐマージ出来ると思う、にしても量がすごいのですごい

@Naturalclar
Apply suggestions from code review
ce655e6 
Co-Authored-By: BSKY <git@bsky.moe>
smorimoto
smorimoto previously approved these changes Jan 26, 2020
View reviewed changes
@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
uetchy
uetchy reviewed Jan 26, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

お疲れ様です🚀

docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
docs/docs/glossary.md Outdated Show resolved Hide resolved
@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned labels Jan 26, 2020
Naturalclar
Naturalclar commented Jan 26, 2020
View reviewed changes
docs/docs/glossary.md Outdated Show resolved Hide resolved
@Naturalclar @uetchy
Apply suggestions from code review
8fd2c1a 
Co-Authored-By: Yasuaki Uechi <y@uechi.io>
@Naturalclar Naturalclar added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 26, 2020
@uetchy uetchy added status: awaiting author response A pull request that is awaiting author's response status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response status: awaiting author response A pull request that is awaiting author's response labels Jan 26, 2020
@uetchy
Copy link
Contributor

uetchy commented Jan 26, 2020

@imbsky 再レビューお願いします！

@smorimoto smorimoto merged commit d62a64d into master Jan 26, 2020
@uetchy uetchy deleted the feat/glossary branch January 27, 2020 03:38
@uetchy uetchy removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uetchy uetchy uetchy approved these changes

@smorimoto smorimoto smorimoto approved these changes

@hirotaka hirotaka Awaiting requested review from hirotaka

Assignees
No one assigned
Labels
core pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Naturalclar @smorimoto @uetchy