Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate tutorial/part-seven/ #85

Merged
merged 10 commits into from
Jan 26, 2020
Merged

Translate tutorial/part-seven/ #85

merged 10 commits into from
Jan 26, 2020
+57 −102

Conversation

grgr-dkrk
Copy link
Contributor

概要

https://www.gatsbyjs.org/tutorial/part-seven/ を翻訳しました。

タイトルはpart-sixの翻訳 #31 に統一しました。

チェックリスト

  • 翻訳スタイルガイド に目を通しました。
  • Translation Guide に目を通しました。
  • textlint を使って校正を行いました（推奨）
  • Allow edits from maintainers にチェックを入れました。

しばらく待ってもレビューが終わらなかったり、必要なレビュー数が足りない状態が続いた場合は、こちらからメンテナーを探して、@を付けてメンションを飛ばしてください。

@smorimoto smorimoto added the status: awaiting review A pull request that is currently awaiting a reviewer's response label Jan 18, 2020
@gatsbybot gatsbybot mentioned this pull request Jan 19, 2020
Open
hirotaka
hirotaka suggested changes Jan 19, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！ 元のドキュメントの内容が難しいのですが、訳は読みやすいと思いました。
訳とは関係ないのですが、原文の改行がわかりずらい 😓
いくつかSuggestionをあげさせていたいだのでご確認お願いいたします。

docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
@hirotaka hirotaka added status: awaiting author response A pull request that is awaiting author's response and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 19, 2020
@grgr-dkrk
Copy link
Contributor Author

@hirotaka ご丁重なレビューありがとうございます！
ご指摘いただいた箇所を修正しましたので、お手数ですがご確認よろしくお願いします。

@hirotaka hirotaka added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 20, 2020
@uetchy uetchy requested a review from hirotaka January 22, 2020 00:36
Naturalclar
Naturalclar suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

いくつか Suggest したので確認おねがいします

@grgr-dkrk
Copy link
Contributor Author

@Naturalclar ありがとうございます！修正しました

Naturalclar
Naturalclar suggested changes Jan 22, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点追加で Suggest しました:pray:

Naturalclar
Naturalclar previously approved these changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます

@Naturalclar Naturalclar added status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned and removed status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 23, 2020
uetchy
uetchy reviewed Jan 23, 2020
View reviewed changes
docs/tutorial/part-seven/index.md Outdated
@@ -1,61 +1,49 @@
---
title: Programmatically create pages from data
title: データからプログラムによるページを作成する
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
title: データからプログラムによるページを作成する
title: データからページをプログラムで作成する

どういう組み合わせ方が一番自然だろうか...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uetchy タイトルは #31 に合わせていますが、suggestionの形式で問題なければ、そちらを採用させていただきます。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

合ってなかった…自分としては suggestion でいければと思っています
その他だと「データからプログラムでページを作成する」「プログラムでデータからページを作成する」でしょうか？

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「プログラムでデータからページを作成する」いいですね。作成より生成の方が自然かもしれません。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます 👍
ただ、記事中のcreateを「作成」で統一しているので、ここだけ「生成」で表記するか、他も「生成」に統一するべきか悩んでいます…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英語では区別していませんが、作成はユーザーによる能動的アクション、生成はプログラムによる結果として使い分けるのが良さそうです。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

表記を変えてみました:bow:

@uetchy uetchy added the status: awaiting author response A pull request that is awaiting author's response label Jan 23, 2020
hirotaka
hirotaka suggested changes Jan 23, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

追加でいくつか Suggestion させていただいのたで、ご確認お願いいたします。

docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
docs/tutorial/part-seven/index.md Outdated Show resolved Hide resolved
@Naturalclar Naturalclar removed the status: awaiting more approval A pull request that is awaiting reviewer #2 to be assigned label Jan 23, 2020
@uetchy uetchy added status: awaiting review A pull request that is currently awaiting a reviewer's response and removed status: awaiting author response A pull request that is awaiting author's response labels Jan 23, 2020
hirotaka
hirotaka previously approved these changes Jan 24, 2020
View reviewed changes
Copy link
Contributor

@hirotaka hirotaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！LGTM 👍

Naturalclar
Naturalclar reviewed Jan 25, 2020
View reviewed changes
docs/tutorial/part-seven/index.md Outdated

Now that you've built a Gatsby site, where do you go next?
あなたは Gatsby のサイトを構築しました。次はどうしますか？
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[imo] 翻訳感が少し強いかも。「あなたは」を外すと少し軽減できそう。

Suggested change
あなたは Gatsby のサイトを構築しました。次はどうしますか？
無事、Gatsby のサイトを構築できましたね！次はどうしますか？

Naturalclar
Naturalclar suggested changes Jan 25, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

再三のレビューで申し訳ない:bow:
1点 Suggest したので確認おねがいします。

Naturalclar
Naturalclar approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@Naturalclar Naturalclar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ありがとうございます

uetchy
uetchy approved these changes Jan 26, 2020
View reviewed changes
Copy link
Contributor

@uetchy uetchy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@uetchy uetchy merged commit f2cc7cb into gatsbyjs:master Jan 26, 2020
@uetchy uetchy added core pages and removed core pages status: awaiting review A pull request that is currently awaiting a reviewer's response labels Jan 26, 2020
@hirotaka hirotaka mentioned this pull request Jan 31, 2020
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uetchy uetchy uetchy approved these changes

@Naturalclar Naturalclar Naturalclar approved these changes

@hirotaka hirotaka hirotaka left review comments

@smorimoto smorimoto Awaiting requested review from smorimoto

Assignees
No one assigned
Labels
core pages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@grgr-dkrk @hirotaka @uetchy @Naturalclar @smorimoto