Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small fixes #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

small fixes #60

wants to merge 1 commit into from

Conversation

mikejw
Copy link

@mikejw mikejw commented Jan 3, 2022

This gets the search page running once built instead of throwing undefined errors.

There are still issues I'm noticing.

  1. The search page isn't populated with all products on first load.
  2. Product links from the search page results have an extra slash in the URI. e.g. "http://www.dev.org/products//cuboid".
  3. Clicking "View empty products" link from an empty cart page loads the search page but doesn't populate it with products. Perhaps the query string needs to be populated with a wildcard (*) somewhere? Perhaps this is related to point 1.
  4. Once deployed there isn't a compiled search page to land on when refreshing the browser at the "/search" URI. I'm using mod_rewrite to redirect to "index.html" however the default routing means the user is redirected to the home page anyway when trying to load "/search..." fresh in the browser.

@mikejw
Copy link
Author

mikejw commented Jan 3, 2022

Closed as per comment this comment #57 (comment), which states the code should be run with a node process (npm run serve) on a VPS.

@mikejw mikejw closed this Jan 3, 2022
@mikejw
Copy link
Author

mikejw commented Jan 3, 2022

I'm reopening this ticket as I'm noticing these errors still appear when using gatsby serve behind a proxy. i.e. nginx. There are errors that prevent the search page from loading which is addressed in the PR. Please ignore points 2 (see separate pull request: #61) and point 4!

@mikejw mikejw reopened this Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant