Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby): use cheap-module-source-map devtool webpack config in develop mode for easier debugging #10083

Merged
merged 1 commit into from Nov 22, 2018

Conversation

shelldandy
Copy link
Contributor

Closes #6278

Sourcemaps are not currently working on gatsby v2. This fixes that on 1 string.

@shelldandy shelldandy requested a review from a team as a code owner November 22, 2018 03:43
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, let's get this in.

@pieh pieh changed the title add sourcemaps on development mode feat(gatsby): use cheap-module-source-map devtool webpack config for easier debugging Nov 22, 2018
@pieh pieh changed the title feat(gatsby): use cheap-module-source-map devtool webpack config for easier debugging feat(gatsby): use cheap-module-source-map devtool webpack config in develop mode for easier debugging Nov 22, 2018
@pieh pieh merged commit ce5cbe8 into gatsbyjs:master Nov 22, 2018
@gatsbot
Copy link

gatsbot bot commented Nov 22, 2018

Holy buckets, @shelldandy — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@pieh
Copy link
Contributor

pieh commented Nov 22, 2018

published gatsby@2.0.55

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
…evelop mode for easier debugging (gatsbyjs#10083)

Closes gatsbyjs#6278

Sourcemaps are not currently working on gatsby v2. This fixes that on 1 string.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🗺 v2 sourcemaps not working (totally NOT styled-components related)
2 participants