Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-plugin-manifest): add option to remove the "theme color" meta tag #10440

Conversation

ivorpad
Copy link
Contributor

@ivorpad ivorpad commented Dec 12, 2018

This fixes #9977

Added an option to remove the "theme color" meta tag from the head.

  • theme_color_in_head is optional, so if it's not set then the meta tag is added.
  • if theme_color_in_head is set to false, then the meta tag is not added
  • if theme_color_in_head is set to true, then the meta tag is added

@ivorpad ivorpad changed the title [gatsby-plugin-manifest] Added option to remove the "theme color" meta tag feat(gatsby-plugin-manifest) Added option to remove the "theme color" meta tag Dec 12, 2018
@pieh
Copy link
Contributor

pieh commented Dec 13, 2018

We would also want to add the option in here - https://github.com/gatsbyjs/gatsby/blob/444b7274a83ac675e19350b81f63671fb928ccc4/packages/gatsby-plugin-manifest/src/__tests__/gatsby-node.js#L70-L74 to make sure that this field doesn't get added to web manifest file

@ivorpad
Copy link
Contributor Author

ivorpad commented Dec 13, 2018

Thanks a lot, Michal. Already pushed the changes. 💪

@pieh
Copy link
Contributor

pieh commented Dec 20, 2018

I think we just miss some documentation updates for it to be merged, so people are aware of that option

@ivorpad ivorpad force-pushed the gatsby-plugin-manifest/add-theme-color-in-head-option branch from c1edbc2 to bc23cd3 Compare December 21, 2018 04:56
@ivorpad ivorpad requested a review from a team December 21, 2018 04:56
@ivorpad
Copy link
Contributor Author

ivorpad commented Dec 21, 2018

Done, @pieh. If there's anything wrong I'd be more than happy to give it another round.

@pieh
Copy link
Contributor

pieh commented Dec 28, 2018

I'll move the documentation part to actual plugin and will merge this

@pieh pieh changed the title feat(gatsby-plugin-manifest) Added option to remove the "theme color" meta tag feat(gatsby-plugin-manifest): add option to remove the "theme color" meta tag Dec 28, 2018
@pieh pieh merged commit 129c5d8 into gatsbyjs:master Dec 28, 2018
@gatsbot
Copy link

gatsbot bot commented Dec 28, 2018

Holy buckets, @ivorpad — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

gpetrioli pushed a commit to gpetrioli/gatsby that referenced this pull request Jan 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-plugin-manifest] Add option to remove theme-color meta tag
3 participants