Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gatsby-source-wordpress): add jwt_base_path option #11425

Merged
merged 2 commits into from
Feb 1, 2019
Merged

feat(gatsby-source-wordpress): add jwt_base_path option #11425

merged 2 commits into from
Feb 1, 2019

Conversation

rotexhawk
Copy link
Contributor

Description

Removes hardcoded JWT token path in gatsby-source-wordpress and passes it in auth options, to support other Wordpress JWT plugins.

Test Passed and the functionality works locally.

@wardpeet wardpeet changed the title Topics/dynamic jwt path wordpress source feat(gatsby-source-wordpress): add jwt_base_path option Jan 31, 2019
@wardpeet
Copy link
Contributor

@rotexhawk Thanks for this PR. Could you perhaps create an issue too with some more information about which plugins and why this is necessary.

Code looks great!

@wardpeet wardpeet added type: feature or enhancement status: awaiting author response Additional information has been requested from the author labels Jan 31, 2019
@rotexhawk
Copy link
Contributor Author

rotexhawk commented Feb 1, 2019

Thanks. I added this issue: #11488

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a bunch! merging!

@wardpeet wardpeet merged commit 8bcd19b into gatsbyjs:master Feb 1, 2019
@rotexhawk rotexhawk deleted the topics/dynamic-jwt-path-wordpress-source branch February 2, 2019 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants