fix(gatsby-cli): Fixed incorrect scriptname in gatsby-cli #12186
Conversation
There was a problem hiding this comment.
@yogeshkotadiya it looks like there are a few breaking changes with yargs 13, notably dropping Node 6 https://github.com/yargs/yargs/blob/master/CHANGELOG.md#breaking-changes
Could you remove the upgrade here, and just encapsulate the changes to the incorrect script name?
DSchau
added
the
status: awaiting reviewer response
There was a problem hiding this comment.
Left a small comment! Thank you for this, @yogeshkotadiya 👍
packages/gatsby-cli/package.json
Outdated
| @@ -28,7 +28,7 @@ | |||
| "source-map": "^0.5.7", | |||
| "stack-trace": "^0.0.10", | |||
| "update-notifier": "^2.3.0", | |||
| "yargs": "^11.1.0", | |||
| "yargs": "12.0.5", | |||
There was a problem hiding this comment.
Since this is also a major semver upgrade, are there any breaking changes we should resolve? Also, should we add a ^ as opposed to pinning the version?
There was a problem hiding this comment.
| "yargs": "12.0.5", | |
| "yargs": "^11.1.0", |
Would probably be better to not change the version at all in this PR, what do you think?
There was a problem hiding this comment.
Just saw that scriptName is 12+
|
Thank you so much, @yogeshkotadiya 👍 |
|
Published in gatsby-cli@2.4.14 |
Description
Resolves incorrect script name in output when using
gatsby --helpcommand.Also removed
yargsconfiguration from package.json because of this warningConfiguring yargs through package.json is deprecated and will be removed in the next major release, please use the JS API instead.TO-DO
Packages upgraded
yargs 11.1.0 -->
13.2.1--> 12.0.5Related Issues
Addresses #12154