-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-cli): Fix --clipboard on Windows #13212
Conversation
ec4183c
to
3a0beba
Compare
Though this gives a better output, node version is still missing here: System: |
@saranshkataria Node version and browsers not showing up seems strange! Can you open an issue in https://github.com/tabrindle/envinfo for this? Does the clipboard stuff work by any chance? |
@sidharthachatterjee this was the output from clipboardy (I installed |
@saranshkataria Oh, alright! I meant to ask if gatsby info --clipboard correctly copied over to the clipboard or not? |
Potentially relevant/useful stack trace at #13274 (comment) |
The above output was copied to the clipboard correctly. Though it is relatively less information than the sample you provided, but it is atleast copying it to the clipboard which was not happening before. |
@sidharthachatterjee same here, funny that edge is detected but nothing else 😄
|
Just reverted the @saranshkataria @wardpeet Can you try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks @sidharthachatterjee! 🌮
|
gatsby info --clipboard
has issues on Windows as documented in #11496envinfo dropped clipboard support in v6 and removed
clipboardy
so using it directly here. Not sure if it will fix #11496 since no behaviour should've changedTodo
Related
tabrindle/envinfo#83 and #11496
Test
npm i gatsby-cli@clipboardy
Other Changes
duplicates
andshowNotFound
options (useful for debugging and cra uses them too)Before
After
(Notice the Not Found for Firefox)