Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sharp] Nodejs 12 API makes gatsby broken #13588

Closed
0xtlt opened this issue Apr 24, 2019 · 1 comment
Closed

[Sharp] Nodejs 12 API makes gatsby broken #13588

0xtlt opened this issue Apr 24, 2019 · 1 comment
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: upstream Issues outside of Gatsby's control, caused by dependencies

Comments

@0xtlt
Copy link

0xtlt commented Apr 24, 2019

Description

Since I have updated nodejs 11 to nodejs 12 some packages don't build anymore surely because of the new native APIs.

Examples :

\node_modules\sharp\src\pipeline.cc(417): error C3861: 'RemoveExifOrientation'
\node_modules\sharp\src\pipeline.cc(436): error C3861: 'ApplyAlpha'

etc...

Steps to reproduce

-Install Nodejs12
-gatsby new nodejstest

And wait for it

Expected result

A normal installation

Actual result

A bug caused by the incompatibility with the new API

Environment

System:
OS: Windows 10
CPU: (16) x64 AMD Ryzen 7 2700X Eight-Core Processor
Binaries:
Yarn: 1.15.2 - C:\Program Files (x86)\Yarn\bin\yarn.CMD
npm: 6.9.0 - C:\Users\Thomas\AppData\Roaming\npm\npm.CMD
Languages:
Python: 3.7.3
Browsers:
Edge: 44.17763.1.0

@pieh
Copy link
Contributor

pieh commented Apr 24, 2019

See lovell/sharp#1668 - this is 2 part issue:

  1. upstream - sharp maintainer mentioned this will be fixed in sharp@0.22.1 (which is not yet released)
  2. in here we will need to update sharp dependencies in few packages

@pieh pieh added status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: upstream Issues outside of Gatsby's control, caused by dependencies labels Apr 24, 2019
@0xtlt 0xtlt closed this as completed Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked This issue/PR can't be solved at the moment and shouldn't be closed/merged type: upstream Issues outside of Gatsby's control, caused by dependencies
Projects
None yet
Development

No branches or pull requests

2 participants