Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-cli): log correct version #13920

Merged
merged 1 commit into from
May 18, 2019
Merged

fix(gatsby-cli): log correct version #13920

merged 1 commit into from
May 18, 2019

Conversation

pyaillet
Copy link
Contributor

@pyaillet pyaillet commented May 8, 2019

Description

Set the cli version consistently for local and global usage

Related Issues

Fixes #13076

@pyaillet pyaillet requested a review from a team as a code owner May 8, 2019 07:15
@LekoArts LekoArts changed the title 🐛 fix gatsby-cli version inconsistency fix(gatsby-cli): version inconsistency May 8, 2019
@wardpeet
Copy link
Contributor

wardpeet commented May 8, 2019

Thanks for patching it! Technically this is correct but like mentioned in the issue yarn gatsby refers to the gatsby package and gatsby refers to gatsby-cli so it's in fact 2 different things but I agree that consistency is key here so I'm in favor of this PR.

What does the rest of @gatsbyjs/core thinks?

Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is technically correct and I favour it since (as mentioned in the issue) consistency between gatsby --version and yarn gatsby --version is key

@pieh made a good point about a user running gatsby --version inside a project to know what version of the gatsby dependency is installed, but I think this can be handled in a later PR as an addition separate from this.

Thank you @pyaillet 👍

@sidharthachatterjee sidharthachatterjee changed the title fix(gatsby-cli): version inconsistency fix(gatsby-cli): log correct version May 18, 2019
@sidharthachatterjee sidharthachatterjee merged commit 649f6d8 into gatsbyjs:master May 18, 2019
@gatsbot
Copy link

gatsbot bot commented May 18, 2019

Holy buckets, @pyaillet — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@sidharthachatterjee
Copy link
Contributor

Published in gatsby-cli@2.5.15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Global vs local gatsby-cli --version inconsistency
3 participants