Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove slash #14372

Merged
merged 3 commits into from
Jun 10, 2019
Merged

remove slash #14372

merged 3 commits into from
Jun 10, 2019

Conversation

woodgear
Copy link
Contributor

Description

remove slash and implement it under utils

Related Issues

#13865

@woodgear woodgear mentioned this pull request May 28, 2019
Closed
superhawk610
superhawk610 suggested changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@superhawk610 superhawk610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo and one additional test and this will be ready to ship 👍

packages/gatsby-source-filesystem/src/__tests__/utils.js Show resolved Hide resolved
packages/gatsby-source-filesystem/src/__tests__/utils.js Outdated Show resolved Hide resolved
woodgear
woodgear commented Jun 7, 2019
View reviewed changes
Copy link
Contributor Author

@woodgear woodgear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this semicolon seems been auto added by pre-commit.

packages/gatsby-source-filesystem/src/__tests__/utils.js Show resolved Hide resolved
superhawk610
superhawk610 approved these changes Jun 7, 2019
View reviewed changes
Copy link
Contributor

@superhawk610 superhawk610 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@superhawk610
Copy link
Contributor

@LekoArts this should be good to go, any idea why the CI is failing?

@freiksenet
Copy link
Contributor

Thanks a lot!

@freiksenet freiksenet merged commit 1d9ba86 into gatsbyjs:master Jun 10, 2019
@gatsbot
Copy link

gatsbot bot commented Jun 10, 2019

Holy buckets, @woodgear — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@m-allanson m-allanson mentioned this pull request Jun 10, 2019
Closed
@woodgear woodgear deleted the feature/slash branch June 17, 2019 15:44
mxxk pushed a commit to mxxk/gatsby that referenced this pull request Jun 21, 2019
@mxxk
feat(gatsby-source-filesystem): remove slash (gatsbyjs#14372)
c09137a 
* remove slash

* remove unnecessary semicolon && add more test

* add test for extended length paths
@yiluomyt
Copy link

yiluomyt commented Jul 8, 2019

Here, I also found a similar problem using gatsby-remark-images, which is also caused by the dependency slash. It will skip the images which contains unicode in file name.

https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-remark-images/src/index.js#L112-L124

johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
@johno
feat(gatsby-source-filesystem): remove slash (gatsbyjs#14372)
3f0b3e9 
* remove slash

* remove unnecessary semicolon && add more test

* add test for extended length paths
@jonniebigodes jonniebigodes mentioned this pull request Sep 19, 2019
Closed
@vladar vladar mentioned this pull request Nov 18, 2019
Merged
@Arno500 Arno500 mentioned this pull request Jan 5, 2020
Closed
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
@freiksenet
feat(gatsby-source-filesystem): remove slash (gatsbyjs#14372)
e3787c5 
* remove slash

* remove unnecessary semicolon && add more test

* add test for extended length paths
Athang663
Athang663 reviewed Sep 4, 2023
View reviewed changes
Copy link

@Athang663 Athang663 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/gatsby-source-filesystem/src/create-file-node.js

packages/gatsby-source-filesystem/src/__tests__/utils.js Show resolved Hide resolved
packages/gatsby-source-filesystem/src/create-file-node.js
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Athang663

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/gatsby-source-filesystem/src/create-file-node.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Athang663 Athang663 Athang663 left review comments

@freiksenet freiksenet freiksenet approved these changes

@superhawk610 superhawk610 superhawk610 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@woodgear @superhawk610 @freiksenet @yiluomyt @Athang663