fix(gatsby-cli): build successfully without optional dependencies #14383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryandrew14
commented
May 29, 2019
| if (semver.satisfies(process.version, `>=8`) && !isCI) { | ||
| let inkExists = false | ||
| try { | ||
| inkExists = require.resolve(`ink`) |
There was a problem hiding this comment.
Just wondering -- why do I see backticks used everywhere for normal strings inside requires? I followed this convention here, but I don't understand why we do it.
There was a problem hiding this comment.
This is just convention we use here. It's much nicer to work with template literals - in case we need to use interpolation we don't have to convert from "normal strings" to template literal
pieh
reviewed
May 29, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue raised in #14370, where trying to build the site after installing without optional dependencies will fail due to
inknot being installed. The change uses the straightforward solution proposed by @wardpeet of ensuring the module exists before using it, and defaulting to yurna in the case that it does not exist.Related Issues
Fixes #14370