fix(gatsby-dev-cli): add missing awaits and other various fixes #14510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiksenet
approved these changes
Jun 4, 2019
|
I'm hitting this issue on an old starter: All ENOENT errors are gone so 👍 |
|
There are some false warnings (X doesn't seem to be installed. restart gatsby-dev to publish it). Those don't really affect things, just are very confusing and just shouldn't be displayed in the middle of publishing dev version of package to verdaccio (will create separate PR for this) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there were couple issues in #14347 did wasn't spotted and that caused some PRs to fail e2e/integration tests because of it
this adds some missing awaits, retry mechanism for copying files (seems like Promise.all copying hundreds of files cause weird ENOENT errors randomly)
EDIT: failing tests on this PR are example of those errors