Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cleanup stack traces for html build errors #15050

Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix: cleanup stack traces for html build errors #15050

merged 1 commit into from
Jun 24, 2019

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Jun 22, 2019

This cleans up stack traces shown on html build errors a bit:

  • removes not useful call sites coming from webpack runtime internals or from .cache
  • removes lib/ in front of src paths, letting users to actually "ctrl/cmd + click" on paths to get editor to proper location

before on the left pane / after on the right pane

Screenshot 2019-06-22 at 20 34 04

@pieh pieh requested a review from a team as a code owner June 22, 2019 18:39
KyleAMathews
KyleAMathews approved these changes Jun 22, 2019
View reviewed changes
Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 🚢

@pieh pieh merged commit d029f7b into gatsbyjs:master Jun 24, 2019
@pieh pieh deleted the no-webpack-nonsense-in-stack branch June 24, 2019 07:50
@KyleAMathews KyleAMathews mentioned this pull request Jun 28, 2019
Closed
@pieh pieh restored the no-webpack-nonsense-in-stack branch May 17, 2020 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KyleAMathews KyleAMathews KyleAMathews approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pieh @KyleAMathews