Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby): various Typescript definitions #15268

Merged
merged 4 commits into from
Jul 2, 2019
Merged

fix(gatsby): various Typescript definitions #15268

merged 4 commits into from
Jul 2, 2019

Conversation

d4rekanguok
Copy link
Contributor

@d4rekanguok d4rekanguok commented Jul 1, 2019

Description

Hi folks, sorry about these droplet of tiny fixes, I wasn't actively looking for issues & only fix them as I go. If you keep this one open for a few days, I'll push here whenever I find more issues.

  • [gatsby] Fix touchNode def so plugin is the 2nd argument instead of being nested in the first one (reference)

  • [gatsby] Fix createRedirect def: make fromPath & toPath the only 2 required fields (reference)

  • [gatsby-source-filesystem] Fix Cache definition in createRemoteFileNode args (related to this one)

  • [gatsby-source-filesystem] add definition for createFileNodeFromBuffer (reference)

Related Issues

@d4rekanguok d4rekanguok requested a review from a team as a code owner July 1, 2019 09:31
@d4rekanguok d4rekanguok changed the title Fix/ts def actions fix(gatsby): Typescript definitions for some of the actions Jul 1, 2019
@d4rekanguok d4rekanguok changed the title fix(gatsby): Typescript definitions for some of the actions fix(gatsby): various Typescript definitions Jul 1, 2019
@freiksenet
Copy link
Contributor

Thanks a lot!

@freiksenet freiksenet merged commit b8f3ed5 into gatsbyjs:master Jul 2, 2019
@sidharthachatterjee
Copy link
Contributor

Published in gatsby-source-filesystem@2.1.2 and gatsby@2.12.1

@d4rekanguok d4rekanguok deleted the fix/ts-def-actions branch July 3, 2019 00:55
johno pushed a commit to johno/gatsby that referenced this pull request Jul 17, 2019
* fix touchNode def

* update createRedirect typings

* [gatsby-source-filesystem] fix cache definition in CreateRemoteFileNodeArgs

* [gatsby-source-filesystem] add definitions for createFileNodeFromBuffer
pragmaticpat pushed a commit to pragmaticpat/gatsby that referenced this pull request Apr 28, 2022
* fix touchNode def

* update createRedirect typings

* [gatsby-source-filesystem] fix cache definition in CreateRemoteFileNodeArgs

* [gatsby-source-filesystem] add definitions for createFileNodeFromBuffer
mwfrost pushed a commit to mwfrost/gatsby that referenced this pull request Apr 20, 2023
* fix touchNode def

* update createRedirect typings

* [gatsby-source-filesystem] fix cache definition in CreateRemoteFileNodeArgs

* [gatsby-source-filesystem] add definitions for createFileNodeFromBuffer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants