feat(gatsby-transformer-sharp): Add default types for ImageSharp #15285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiksenet
reviewed
Jul 2, 2019
| @@ -43,7 +43,15 @@ exports.sourceNodes = ( | |||
| { actions, getNode, createNodeId, hasNodeChanged, reporter, emitter }, | |||
| pluginOptions | |||
| ) => { | |||
| const { createNode, deleteNode } = actions | |||
There was a problem hiding this comment.
Use createSchemaCustomization instead of sourceNodes.
There was a problem hiding this comment.
If we would use createSchemaCustomization here, users would be required to run at least gatsby@2.12.0 and it will inevitably cause issues for people updating just plugin and not core gatsby package.
IMO, if this is just more correct API to use, but doesn't ultimately change how things work, it's just safer to keep it in sourceNodes (at least until we need to do major release for that plugin where we can bump minimal supported Gatsby version without interupting users)
| @@ -18,3 +18,15 @@ exports.onPreExtractQueries = async ({ store, getNodesByType }) => { | |||
| `${program.directory}/.cache/fragments/image-sharp-fragments.js` | |||
| ) | |||
| } | |||
|
|
|||
| exports.sourceNodes = ({ actions }) => { | |||
There was a problem hiding this comment.
Ditto about createSchemaCustomization.
Co-Authored-By: Mikhail Novikov <freiksenet@gmail.com>
sidharthachatterjee
changed the title
sidharthachatterjee
changed the title
freiksenet
approved these changes
Jul 2, 2019
|
Published in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that themes is almost ready to go, we've surfaced upon an issue in ChristopherBiscardi/gatsby-themes-stable-test#1 where a theme without any content will break with
This occurs because the node the above definition is trying to create a fragment on (
ImageSharp) doesn't exist because no image file was present in the project.To fix this, we need to add default types for
ImageSharp,Fileand more in the respective plugins that own them.CC @freiksenet @pieh @KyleAMathews