Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(gatsby-image): Update TypeScript types #15313

Merged
merged 1 commit into from
Jul 2, 2019
Merged

fix(gatsby-image): Update TypeScript types #15313

merged 1 commit into from
Jul 2, 2019

Conversation

brimtown
Copy link
Contributor

@brimtown brimtown commented Jul 2, 2019 •
edited

Description

In the course of merging #13395, the implementation was switched from using separate
fluidImages and fixedImages props to overloading fluid and fixed to take arrays.
The TypeScript types were not updated to match this. This fixes the types to reflect that: https://www.gatsbyjs.org/packages/gatsby-image/#gatsby-image-props

@brimtown brimtown requested a review from a team as a code owner July 2, 2019 15:41
@brimtown brimtown requested a review from wardpeet July 2, 2019 17:00
wardpeet
wardpeet approved these changes Jul 2, 2019
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh my bad, thanks for fixing!

@wardpeet wardpeet merged commit 88e5766 into gatsbyjs:master Jul 2, 2019
@sidharthachatterjee
Copy link
Contributor

Published in gatsby-image@2.2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brimtown @sidharthachatterjee @wardpeet