fix: don't break joi validation for unhandledRejections & apirunner #15600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Jul 10, 2019
|
Unhandled rejections API runner: |
wardpeet
commented
Jul 10, 2019
| // reason can be anything, it can be a message, an object, ANYTHING! | ||
| // we convert it to an error object so we don't crash on structured error validation | ||
| if (!(reason instanceof Error)) { | ||
| reason = new Error(util.format(reason)) |
There was a problem hiding this comment.
no idea how to improve this, so I'm happy to accept suggestions
There was a problem hiding this comment.
Yeah, seems pretty reasonable 👍
Co-Authored-By: Michal Piechowiak <misiek.piechowiak@gmail.com>
pieh
reviewed
Jul 10, 2019
KyleAMathews
previously approved these changes
Jul 10, 2019
pieh
approved these changes
Jul 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Structured logging as some flaws in our code. These changes don't fix evertyhing but they fix the ones that are mentioned in the issues.
unhandledRejection is a hard event to format into a structured log. The reason why it fails can be anything (ex:
Promise.reject({ errors: ["I don't care"]})). This PR formats into a string so we at least don't break. UnhandledRejection should only occur on users code and not plugins as we should be guarded against this.The other fix is that I converted our api runner into a structured error as not every error was compatible. We want plugins to use structured logging themselves but for now, this fixes weird errors thrown in plugins.
Related Issues
Fixes #15487
Partially fixes #15242