fix: don't break joi validation for production bundles webpack errors #15602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things tackled here:
reporter.errordoesn't handle(message: string, errors: Array)signatureFriendlyErrorsWebpackPlugincurrently). For now it's generic error, but later will probably expand and we could cloneFriendlyErrorsWebpackPluginerror handling and swap development to use our errors (and enable clearing console from fixed errors and only display ones that are not fixed yet)Example output:
Question - should webpack compilation errors in
build-javascriptandbuild-htmlshare same ids? For now it would be easy separate them as we have single generic webpack error id, but if add more specific ones for some cases, this might be messy.Partially fixes #15242