Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(docs): Clarify gatsby-plugin-mdx requirements for gatsby-source-filesystem #15604

Merged
merged 5 commits into from
Aug 1, 2019
Merged

feat(docs): Clarify gatsby-plugin-mdx requirements for gatsby-source-filesystem #15604

merged 5 commits into from
Aug 1, 2019

Conversation

yamalight
Copy link
Contributor

Description

Adds an example code and additional note explaining that mdx plugin needs to have filesystem pre-processing files.

Related Issues

#15594

…filesystem

Adds an example code and additional note explaining that mdx plugin needs to have filesystem pre-processing files.
Ref: #15594
@jonniebigodes
Copy link

@yamalight fine on my end. I'll leave to core team to review it and possibly merge it.

@marcysutton
Copy link
Contributor

Ooh, great addition! The PR needs to be updated to use the current plugin version: gatsby-plugin-mdx and then it should be good to go.

Thanks for working on this!

@yamalight
Copy link
Contributor Author

@marcysutton should be updated now I think 🤔

Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Added a couple suggestions and had a question for you.

packages/gatsby-plugin-mdx/README.md Outdated Show resolved Hide resolved
packages/gatsby-plugin-mdx/README.md Show resolved Hide resolved
packages/gatsby-plugin-mdx/README.md Outdated Show resolved Hide resolved
yamalight and others added 2 commits July 24, 2019 11:09
Co-Authored-By: John Otander <johnotander@gmail.com>
Co-Authored-By: John Otander <johnotander@gmail.com>
@sidharthachatterjee sidharthachatterjee added the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Jul 24, 2019
@johno johno removed the status: awaiting reviewer response A pull request that is currently awaiting a reviewer's response label Jul 31, 2019
Copy link
Contributor

@johno johno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✨ lgtm!

@johno
Copy link
Contributor

johno commented Aug 1, 2019

Thanks @yamalight!

@johno johno merged commit d08323c into gatsbyjs:master Aug 1, 2019
@gatsbot
Copy link

gatsbot bot commented Aug 1, 2019

Holy buckets, @yamalight — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants