Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-plugin-mdx): Fix graphql query examples in readme #15691

Merged
merged 5 commits into from
Jul 19, 2019

Conversation

CrashWire
Copy link
Contributor

Description

19f7396 breaks the example provided in the readme. This updates the readme to fix it.

@CrashWire CrashWire requested a review from a team as a code owner July 13, 2019 21:54
@mrozilla
Copy link
Contributor

@CrashWire I was just looking into this! You might want to also update the two other places in the docs where it’s mentioned to make sure the change is complete :)

In your commit, that’s line 443 (where it’s consumed from the query) and line 433 (where it’s mentioned in the context of additional props)

@CrashWire
Copy link
Contributor Author

CrashWire commented Jul 14, 2019

You might want to also update the two other places in the docs where it’s mentioned to make sure the change is complete :)

In your commit, that’s line 443 (where it’s consumed from the query) and line 433 (where it’s mentioned in the context of additional props)

@mrozilla Thanks for helping spot the omissions! I’ve made the changes in 35c12f5.

Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've stumbled upon this myself. One small question added. Besides that, this looks great.

packages/gatsby-plugin-mdx/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've stumbled upon this myself. One small question added. Besides that, this looks great.

@wardpeet wardpeet changed the title Update gatsby-plugin-mdx readme example fix(gatsby-plugin-mdx): Fix graphql query examples in readme Jul 15, 2019
@wardpeet wardpeet added the status: awaiting author response Additional information has been requested from the author label Jul 15, 2019
Co-Authored-By: Ward Peeters <ward@coding-tech.com>
@CrashWire
Copy link
Contributor Author

@wardpeet That seems to be right!

(I was also trying to figure out if @ChristopherBiscardi might have had a reason to include the beginning ; in 75d4942#diff-bc334e48d29c57bb3c32c0764b5e4242L450, but couldn’t think of any.)

@amberleyromo amberleyromo added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 19, 2019
@gatsbybot gatsbybot merged commit c64d322 into gatsbyjs:master Jul 19, 2019
@gatsbot
Copy link

gatsbot bot commented Jul 19, 2019

Holy buckets, @CrashWire — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes status: awaiting author response Additional information has been requested from the author
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants