Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-cypress): Add ability to pass in options in getTestElement #15743

Merged
merged 1 commit into from
Jul 15, 2019
Merged

feat(gatsby-cypress): Add ability to pass in options in getTestElement #15743

merged 1 commit into from
Jul 15, 2019

Conversation

sidharthachatterjee
Copy link
Contributor

Read the title

@sidharthachatterjee sidharthachatterjee requested a review from a team as a code owner July 15, 2019 15:22
DSchau
DSchau approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@DSchau DSchau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌 Guessing this is solving something, but yeah, makes sense!

pieh
pieh approved these changes Jul 15, 2019
View reviewed changes
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, let's wait for tests to see if empty options object doesn't mess with existing tests

@sidharthachatterjee
Copy link
Contributor Author

@DSchau Yeah, CircleCI workers are a little slow so I need this to bump up the timeout on #15739 (hot reloads takes longer than default timeout of 4 seconds)

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Jul 15, 2019
@gatsbybot gatsbybot merged commit 8eaddef into master Jul 15, 2019
@sidharthachatterjee sidharthachatterjee deleted the feat/options-in-gatsby-cypress branch July 15, 2019 15:36
madmonkey pushed a commit to madmonkey/gatsby that referenced this pull request Jul 15, 2019
@sidharthachatterjee @madmonkey
feat(gatsby-cypress): Add ability to pass in options in getTestElement (
dba8778 
gatsbyjs#15743)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pieh pieh pieh approved these changes

@DSchau DSchau DSchau approved these changes

Assignees
No one assigned
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sidharthachatterjee @pieh @DSchau @gatsbybot