fix(gatsby-source-wordpress): WordPress does not properly encode its media urls #15593 #15835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If wordpress media URLs contain non-ASCII characters, then they will not get properly encoded by wordpress. This makes them invalid URLs and they get ignored by `gatsby-source-filesystem`. This causes the media files to not exist locally.
|
This is awesome! 👏 Thank you for doing this. could you provide an example project/api so we can have a proper test run? |
wardpeet
approved these changes
Jul 19, 2019
|
This would probably also fix #12684. 🙌🏼 |
pieh
approved these changes
Jul 22, 2019
There was a problem hiding this comment.
Verified locally with some image containing non-ASCII characters. Thanks @TitanNano!
|
Holy buckets, @TitanNano — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
johno
pushed a commit
to johno/gatsby
that referenced
this pull request
Jul 29, 2019
…byjs#15835) If wordpress media URLs contain non-ASCII characters, then they will not get properly encoded by wordpress. This makes them invalid URLs and they get ignored by `gatsby-source-filesystem`. This causes the media files to not exist locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If WordPress media URLs contain non-ASCII characters, then they will not get properly encoded by WordPress. This makes them invalid URLs, and they get ignored by
gatsby-source-filesystem. This causes the media files to not exist locally.Related Issues
Fixes #15593