feat(gatsby-source-wordpress): Add keepMediaDetails

[billyjacoby]

Description

This will enable users to toggle sourceThumbnails in order to decide whether or not thumbnail info is downloaded.

I needed this in order to build an image carousel that didn't warrant the highest quality photos to speed up site load times.

Related Issues

Fixes #6509

[amberleyromo]

@gatsbyjs/learning is tagged on this, but more appropriate for @gatsbyjs/core -- will leave for y'all!

[sidharthachatterjee]

You seem to have pushed built files in src/gatsby-node.js

Could you please push the src (without transpilation)? Also, it would be nice to add a test for this new option.

[sidharthachatterjee]

Closing this for now since the changes are hard to grok with transpiled code

Let's re open after pushing untranspiled code and take it from there!

[billyjacoby]

I just committed the changes to my fork, sorry about that!

[billyjacoby]

You seem to have pushed built files in src/gatsby-node.js

Could you please push the src (without transpilation)? Also, it would be nice to add a test for this new option.

This is done!

[sidharthachatterjee]

@billyjacoby No problem. Thanks for fixing! Could you please fix conflicts and add a test for the new option! Otherwise, looks good! 🙌🏼

[billyjacoby]

@billyjacoby No problem. Thanks for fixing! Could you please fix conflicts and add a test for the new option! Otherwise, looks good! 🙌🏼

Conflicts are resolved.

As for adding tests, "it's a bit tricky to mock as it needs to access to the store/cache + would download file.." according to the existing code base. To be honest I'm not sure how I'd go about mocking all of that...

[sidharthachatterjee]

gatsby-source-wordpress/src/normalize.js still appears to be transpiled code 😞

Could you please push the source so I can review this?

As for adding tests, "it's a bit tricky to mock as it needs to access to the store/cache + would download file.." according to the existing code base. To be honest I'm not sure how I'd go about mocking all of that...

Just took a look. Fair enough. Since this is fairly simple (only 'keeps' some keys that would otherwise be deleted) I think we can skip testing this till we figure out how to better mock the download and store etc

[sidharthachatterjee]

Left two comments!

[billyjacoby]

gatsby-source-wordpress/src/normalize.js still appears to be transpiled code 😞

Could you please push the source so I can review this?

As for adding tests, "it's a bit tricky to mock as it needs to access to the store/cache + would download file.." according to the existing code base. To be honest I'm not sure how I'd go about mocking all of that...

Just took a look. Fair enough. Since this is fairly simple (only 'keeps' some keys that would otherwise be deleted) I think we can skip testing this till we figure out how to better mock the download and store etc

I totally just forgot to push after making the changes locally last night. Should be good to go now.

[sidharthachatterjee]

@billyjacoby Thanks! What do you think about renaming the option?

[billyjacoby]

@billyjacoby Thanks! What do you think about renaming the option?

I'm totally fine with it. That was just the most concise name I could think of, but naming is certainly not my strong suite😅 ...

[sidharthachatterjee]

@billyjacoby Oops, I hit the wrong button hah

No worries. Naming is hard! Go ahead and make the change then and we'll get this shipped 💃

[billyjacoby]

@billyjacoby Oops, I hit the wrong button hah

No worries. Naming is hard! Go ahead and make the change then and we'll get this shipped 💃

Done! I liked your name better than mine, so thanks for that! 😬

[sidharthachatterjee]

@billyjacoby Can you please give me push access to your fork? Just did a little clean up and tried to push

I'll add that in a follow up! Merging this in now

[pieh]

We still should pass reporter to normalize.downloadMediaFiles

[sidharthachatterjee]

Fixing that in #16670

Not published yet anyway

[sidharthachatterjee]

Renamed this to keepMediaSizes in #16670 because I realised we were deleting sizes and not media_details

Sorry for the back and forth @billyjacoby

[sidharthachatterjee]

Published in gatsby-source-wordpress@3.1.16