[gatsby-plugin-offline] creates link prefetch from link preconnect

[cluk3]

Description

I have both gatsby-plugin gatsby-plugin-google-analytics and gatsby-plugin-offline installed.
When running lighthouse in production, it gives me the following warning:

Which is weird cause I'm not consuming any resource from https://marketingplatform.google.com 🤔
So i started investigating and found out that basically this is coming from 2 redirects:

If you look closely the initiator is gatsby-browser.
What is happening under the hood is that gatsby-plugin-google-analytics is adding a <link rel="preconnect dns-prefetch" href="https://www.google-analytics.com"> (

gatsby/packages/gatsby-plugin-google-analytics/src/gatsby-ssr.js

Line 27 in 4ba06ab

<link

)
and gatsby-plugin-offline is then consuming this link an creating a link prefetch from its href 😱

Steps to reproduce

Having both the plugins above mentioned should work. You can check this starter as a reference: https://github.com/LekoArts/gatsby-starter-portfolio-cara and run lighthouse on the production demo: https://cara.lekoarts.de

Expected result

gatsby-plugin-offline should ignore link preload · prefetch · preconnect · dns-prefetch

Actual result

it just take all the links and creates a link prefetch from them.

Environment

  System:
    OS: macOS High Sierra 10.13.6
    CPU: (4) x64 Intel(R) Core(TM) i5-5350U CPU @ 1.80GHz
    Shell: 5.3 - /bin/zsh
  Binaries:
    Node: 10.12.0 - ~/n/bin/node
    Yarn: 1.9.4 - /usr/local/bin/yarn
    npm: 6.9.0 - ~/n/bin/npm
  Languages:
    Python: 2.7.10 - /usr/bin/python
  Browsers:
    Chrome: 75.0.3770.142
    Safari: 12.1.1
  npmPackages:
    gatsby: ^2.13.21 => 2.13.27 
    gatsby-image: ^2.2.6 => 2.2.6 
    gatsby-plugin-google-analytics: ^2.1.4 => 2.1.4 
    gatsby-plugin-manifest: ^2.2.3 => 2.2.3 
    gatsby-plugin-netlify: ^2.1.3 => 2.1.3 
    gatsby-plugin-offline: ^2.2.4 => 2.2.4 
    gatsby-plugin-react-helmet: ^3.1.2 => 3.1.2 
    gatsby-plugin-sharp: ^2.2.7 => 2.2.8 
    gatsby-plugin-sitemap: ^2.2.3 => 2.2.3 
    gatsby-plugin-styled-components: ^3.1.2 => 3.1.2 
    gatsby-plugin-tailwindcss: ^1.0.3 => 1.0.3 
    gatsby-plugin-webpack-bundle-analyzer: ^1.0.5 => 1.0.5 
    gatsby-source-filesystem: ^2.1.5 => 2.1.5 
    gatsby-transformer-sharp: ^2.2.3 => 2.2.4 
  npmGlobalPackages:
    gatsby-cli: 2.7.15

[cluk3]

If this is really an issue and not the expected behaviour I'd be happy to discuss a possible solution and submit a PR with the fix

[eknowles]

does this change when reformatting the ordering of the plugins in gatsby-config?

[cluk3]

Yes, if I put gatsby-plugin-google-analytics after gatsby-plugin-offline it doesn't happen anymore, but I still think gatsby-plugin-offline should ignore link preload · prefetch · preconnect · dns-prefetch as a final and clean solution. Thanks anyway, it works amazingly as an hotfix :)

[gatsbot]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.

If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[gatsbot]

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.

Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community!