fix(docs): add note for exception when using gatsby-source-contentful #15926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using gatsby-transformer-sharp along with gatsby-source-contentful, while using the default behavior of the source plugin to link to Contentful's CDN instead of downloading the assets to the to the local filesystem, results in a warning during compiling.
jokokoloko
added
the
type: documentation
Co-Authored-By: Kitten King <53072918+kittenking@users.noreply.github.com>
gillkyle
previously approved these changes
Aug 7, 2019
There was a problem hiding this comment.
Thanks for adding this note @jokokoloko 🙂 I moved the exception note down into the other paragraph and put a little Note tag in front of it to call it out as more of an exception.
m-allanson
added a commit
that referenced
this pull request
Aug 9, 2019
* master: (67 commits) chore(starters): add gatsby-starter-profile-site (#16433) Update tailwind-css.md CSS-in-JS instructions (#16443) fix: update dependency theme-ui to ^0.2.31 (#16436) chore(gatsby): Improve typings for reporter (#16441) docs(gatsby-remark-images): Fix description of showCaptions (#16442) fix(tests): Remove unreliable timeout logic from development-runtime (#16454) fix(docs): adds back some missing guides to sidebar (#16437) chore(sites): add coffee shop creative (#16447) Add "Using Google Fonts" recipe to Style section (#15911) fix(docs): add note for exception when using gatsby-source-con… (#15926) chore(starters): Update username in starter entry (#16413) chore(docs): added note about shorter titles and breadcrumbTit… (#16438) feat(blog): Theme Jam wrap-up post (#16440) docs(gatsby-plugin-layout): fix bracket typos (#16418) docs: fix minor grammar in remark plugin tutorial (#16435) feat(gatsby-remark-primsjs): Support overriding prompt user/host. (#16421) docs(themes): Wrong file name in building theme docs (#16430) chore(showcase): Add QuantumBlack (#16426) blog(www): Gazette August Edition (#16404) chore(docs): add note for app shell and its meaning in server logs (#16423) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
gatsby-transformer-sharpalong withgatsby-source-contentful, while using the default behavior of the source plugin to link to Contentful's CDN instead of downloading the assets to the to the local filesystem, results in a warning during compiling.Description
Extended the existing note to mention that using
gatsby-transformer-sharptogether withgatsby-source-contentful, while using the default behavior of the source plugin to link to Contentful's CDN instead of downloading the assets to the local filesystem, results in a warning during compiling.The
gatsby-source-contentfulplugin creates aContentfulAssetnode for every image with links to Contentful’s CDN whilegatsby-transformer-sharpcan not find any assets to generate nodes for.The warning:
ImageSharp nodes generated:
ContentfulAsset nodes generated:
Related Issues
https://www.gatsbyjs.org/packages/gatsby-source-contentful/#download-assets-for-static-distribution