-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(gatsby-plugin-mdx): Replaces to-style with style-to-object #16062
fix(gatsby-plugin-mdx): Replaces to-style with style-to-object #16062
Conversation
This is no longer required as all values returned from `style-to-object` are strings
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙏
Thanks for taking this on and getting in a fix @pedrolamas!
My other PR in Anyone using the latest
This is because Gatsby is trying to use I made sure to add the |
I hope someone on @gatsbyjs/core is actually reading my message above and will be able to validate the current problem (and that this PR fixes it) |
Hmmm, are you using |
Good point @johno! For some weird reason, seems I was using the deprecated Given this, should I rebase my changes in this PR to ensure that |
I merged in those other changes to your changes already, so we'll probably merge this in and release shortly! |
Partially fixes #15058
Similar changes are required on Mdx and I've already submitted a PR for them (which once pushed, will require an update of the dependency in Gatsby)