fix(gatsby-plugin-mdx): Raise error if MDXRenderer receives undefined or null #16555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should validate that MDXRenderer receives a transpiled MDX string. If we don't, we should error out with a useful error message. This is related to gatsbyjs#16481, but doesn't completely solve all causes. An additional PR will follow later.
sidharthachatterjee
previously approved these changes
Aug 13, 2019
sidharthachatterjee
changed the title
johno
added a commit
to johno/gatsby
that referenced
this pull request
Aug 13, 2019
This deviates from React conventions and there are valid usecases where content passed to MDXRenderer might be stateful meaning that it might be undefined at some point. Related/reverts gatsbyjs#16555
johno
added a commit
to johno/gatsby
that referenced
this pull request
Aug 13, 2019
This deviates from React conventions and there are valid usecases where content passed to MDXRenderer might be stateful meaning that it might be undefined at some point. Related/reverts gatsbyjs#16555
gatsbybot
pushed a commit
that referenced
this pull request
Aug 13, 2019
This deviates from React conventions and there are valid usecases where content passed to MDXRenderer might be stateful meaning that it might be undefined at some point. Related/reverts #16555
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should validate that MDXRenderer receives a transpiled MDX
string. If we don't, we should error out with a useful error
message.
This is related to #16481, but doesn't completely solve all causes.
An additional PR will follow later.