-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gatsby-cli): Add success message after installing gatsby #17241
feat(gatsby-cli): Add success message after installing gatsby #17241
Conversation
Apparently I was only cleaning up the I don't want to hardcode all the stuff from cli I tried importing the Any help? |
Hmm, kind of chicken and egg problem here. We don't really want to run this script when installing dependencies in our monorepo or when building |
Also few notes:
|
One benefit here is that yarn doesn't show postinstall logs of dependant packages 😛. Npm does so we still have to find a workaround for this. |
I was just testing, and
I'm thinking what we could do is in install script we could import from |
@pieh Is there maybe an environment variable which we can use when we are installing things in the monorepo or when building the
I will make these changes. Thank you for the suggestions!
Let me try this and a couple of ideas that I have in mind and get back to you guys. Thanks a lot for all the suggestions and comments. Cheers! |
Can anyone please help me out here. I am not sure why the tests are failing. Seems like some dependencies are missing. Did I break it in my changes? I don't think I touched any of the dependencies in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I tested all platforms and only npm show it while installing it globally and regularly. I feel like we can move forward with this. A local npm install is a bit unfortunate but 🤷♂.
I've added a few comments about the postinstall code.
…ritraj/gatsby into cli/install-welcome-message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me ;)
Holy buckets, @anamritraj — we just merged your PR to Gatsby! 💪💜 Gatsby is built by awesome people like you. Let us say “thanks” in two ways:
If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’. Thanks again! |
Published in |
Description
Show custom message when a user does
npm install gatsby-cli
to installgatsby-cli
.Adds a nice looking success message and point users to the Gatsby documentation website.
Also, shows the commands available to the cli users (default help prompt).
Related Issues
Fixes #13511