Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: add details about the CI environment variable available to gatsby build for dumb terminals #17966

Merged
merged 2 commits into from
Oct 1, 2019
Merged

Docs: add details about the CI environment variable available to gatsby build for dumb terminals #17966

merged 2 commits into from
Oct 1, 2019

Conversation

brettinternet
Copy link
Contributor

@brettinternet brettinternet commented Sep 28, 2019

Description

Some dumb terminals print to the console excessively with Gatsby's build output, printing a new line for each animation.

gatsby build animations per line in jenkins

While ci-info does detect many CI/CD environments, it may be necessary to explicitly declare CI=true to make ci-info aware of its CI environment. As far as I understand, ci-info's module isCI conditionally determines whether ink will be used to update build activity to the console.

In addition to CI, the multi-core build environment variable is relevant to document alongside since both are likely to be useful in virtual integration environments, as I found in constructing my own build pipeline with Gatsby. Some connection should be made from gatsby build to the available environmental variable side effects.

Related Issues

Addresses #17873

@brettinternet brettinternet requested a review from a team as a code owner September 28, 2019 07:50
@brettinternet brettinternet changed the title Document the CI environment variable available to gatsby build for dumb terminals Docs: add details about the CI environment variable available to gatsby build for dumb terminals Sep 28, 2019
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you so much 🥇

@sidharthachatterjee sidharthachatterjee added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Oct 1, 2019
@gatsbybot gatsbybot merged commit c9aeb07 into gatsbyjs:master Oct 1, 2019
@gatsbot
Copy link

gatsbot bot commented Oct 1, 2019

Holy buckets, @brettinternet — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

@brettinternet brettinternet deleted the docs/build-env-vars branch October 1, 2019 02:28
pvdz added a commit that referenced this pull request Nov 28, 2019
…his way

This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max.

This drops the govbook benchmark from 210 seconds down to 140 seconds.

Fixes #15505
Fixes #17452
Fixes #17966
Fixes #18801

Relates to #17873
Relates to vadimdemedes/ink#212
gatsbybot pushed a commit that referenced this pull request Nov 28, 2019
…19866)

* perf(gatsby-cli): throttle progress bar, build significantly faster this way

This change explicitly throttles the progress bar updates (`tick` and `total`) to be clamped to 10 fps max.

This drops the govbook benchmark from 210 seconds down to 140 seconds.

Fixes #15505
Fixes #17452
Fixes #17966
Fixes #18801

Relates to #17873
Relates to vadimdemedes/ink#212

* Force flush on done() and use local var for total
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants