Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(gatsby-cli): Add instructions after new #18332

Merged
merged 7 commits into from
Oct 14, 2019
Merged

feat(gatsby-cli): Add instructions after new #18332

merged 7 commits into from
Oct 14, 2019

Conversation

anikethsaha
Copy link
Contributor

Description

In this PR, I have added an after setup instruction for the gatbsy-cli new command.
Which looks something like this..

image

The above log will be printed when the installation and project setup is getting successful

Related Issues

N/A

@anikethsaha anikethsaha requested a review from a team as a code owner October 8, 2019 16:49
@anikethsaha anikethsaha changed the title chore: added after-setup instrutions for new command [CLI] : added after-setup instrutions for new command Oct 8, 2019
sidharthachatterjee
sidharthachatterjee suggested changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of suggestions! Thank you so much 🥇

packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
packages/gatsby-cli/src/init-starter.js Outdated Show resolved Hide resolved
anikethsaha and others added 6 commits October 9, 2019 21:08
@anikethsaha @sidharthachatterjee
chore(cli): more detailed message for success message !
f26dbaf 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha @sidharthachatterjee
chore(cli): removed not-required message line
1b9a8ab 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha @sidharthachatterjee
chore(cli): change the method name from endInstruction to successMessage
c7a954f 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha @sidharthachatterjee
chore(cli): removed the async and replaced the new method name
a1be0cc 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha @sidharthachatterjee
chore(cli): changed the path variable
8492690 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha @sidharthachatterjee
chore(cli): changed the develop script caller
1453aa0 
Co-Authored-By: Sidhartha Chatterjee <me@sidharthachatterjee.com>
@anikethsaha
Copy link
Contributor Author

I added those suggestions 👍

@lannonbr lannonbr changed the title [CLI] : added after-setup instrutions for new command feat(gatsby-cli): Add after-setup instrutions for new command Oct 11, 2019
@lannonbr lannonbr added the topic: cli Related to the Gatsby CLI label Oct 11, 2019
sidharthachatterjee
sidharthachatterjee approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@sidharthachatterjee sidharthachatterjee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@sidharthachatterjee sidharthachatterjee changed the title feat(gatsby-cli): Add after-setup instrutions for new command feat(gatsby-cli): Add instructions after new Oct 14, 2019
@sidharthachatterjee sidharthachatterjee merged commit a1dffac into gatsbyjs:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muescha muescha muescha left review comments

@pieh pieh pieh left review comments

@wardpeet wardpeet wardpeet left review comments

@sidharthachatterjee sidharthachatterjee sidharthachatterjee approved these changes

Assignees
No one assigned
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@anikethsaha @muescha @pieh @wardpeet @sidharthachatterjee @lannonbr