Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "boundActionCreators" to just actions #1909

Closed
KyleAMathews opened this issue Aug 24, 2017 · 3 comments
Closed

Rename "boundActionCreators" to just actions #1909

KyleAMathews opened this issue Aug 24, 2017 · 3 comments
Assignees

Comments

@KyleAMathews
Copy link
Contributor

@KyleAMathews KyleAMathews commented Aug 24, 2017

I went with boundActionCreators as that's what they are in Redux but… nobody actually knows (or should care) that we're using Redux under the hood so we could give these functions a much more graceful name e.g. just actions or commands.

Thoughts?

We could do this as part of #1824

@KyleAMathews

This comment has been minimized.

Copy link
Contributor Author

@KyleAMathews KyleAMathews commented Aug 24, 2017

Or we could just do this now as a non-breaking change. Pass both to APIs but change the docs to use the new name.

@Redmega

This comment has been minimized.

Copy link

@Redmega Redmega commented Aug 25, 2017

I like the idea of aliasing boundActionCreators to actions and deprecating the boundActionCreators api. Maybe log a warning to console that using the old name is deprecated.

@KyleAMathews

This comment has been minimized.

Copy link
Contributor Author

@KyleAMathews KyleAMathews commented Aug 26, 2017

We shouldn't mark boundActionCreators depreciated until v2 though.

@jquense jquense mentioned this issue Dec 19, 2017
7 of 13 tasks complete
@calcsam calcsam self-assigned this Jan 11, 2018
@calcsam calcsam moved this from To Do to In progress in Gatsby v2 Release Jan 11, 2018
@KyleAMathews KyleAMathews changed the title RFC: rename "boundActionCreators" to just actions Rename "boundActionCreators" to just actions Jan 12, 2018
@calcsam calcsam moved this from In progress to Done in Gatsby v2 Release Jan 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
3 participants
You can’t perform that action at this time.