Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Guidelist header to Table of Contents #19291

Closed
gillkyle opened this issue Nov 5, 2019 · 6 comments
Closed

add Guidelist header to Table of Contents #19291

gillkyle opened this issue Nov 5, 2019 · 6 comments
Labels
stale? Issue that may be closed soon due to the original author not responding any more.

Comments

@gillkyle
Copy link
Contributor

gillkyle commented Nov 5, 2019

Problem

As described in this PR comment: https://github.com/gatsbyjs/gatsby/pull/19214/files#r342771110 the Guidelist gets "swallowed" up in Reference Guide articles that have a lot of content because it's not included in the Table of Contents (like the proposed changes in that PR or like this example: https://www.gatsbyjs.org/docs/mdx/)

In pages like this one:

image

There should be a way to link to this "In this section" content from the Table of Contents:

image

What changes should be made

The exact nature of what should be changed to make this work is unclear. I haven't done much digging but possible avenues for fixing this could be:

  • Adding the ability to pass something into the Table of Contents component somewhere
  • Detecting if the Guidelist is on a page in the docs-template and adding the header to the ToC
  • Digging into how gatsby-plugin-mdx creates the tableOfContents and seeing if inline components can be included as a part at build time

Researching a good solution and then implementing it would help several of those pages where the ToC is harder to see.

@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Nov 27, 2019
@github-actions
Copy link

github-actions bot commented Dec 7, 2019

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

@github-actions github-actions bot closed this as completed Dec 7, 2019
@muescha
Copy link
Contributor

muescha commented Dec 8, 2019

But if there is just a sport teaser on an "index page" then double guidelists are a way to much.

How about as workaround:

  • add the guidelist component twice (at beginning and at the end)
  • add a header before the guidelist, then this is available in TOC

@wardpeet wardpeet added not stale and removed stale? Issue that may be closed soon due to the original author not responding any more. labels Dec 16, 2019
@wardpeet wardpeet reopened this Dec 16, 2019
@LekoArts LekoArts added topic: website and removed help wanted Issue with a clear description that the community can help with. not stale labels May 25, 2020
@github-actions
Copy link

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 15, 2020
@muescha muescha removed the stale? Issue that may be closed soon due to the original author not responding any more. label Jun 15, 2020
@github-actions
Copy link

github-actions bot commented Jul 6, 2020

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

@github-actions github-actions bot added the stale? Issue that may be closed soon due to the original author not responding any more. label Jul 6, 2020
@github-actions
Copy link

Hey again!

It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it.
Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m HUMAN_EMOTION_SORRY. Please feel free to reopen this issue or create a new one if you need anything else.
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks again for being part of the Gatsby community! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale? Issue that may be closed soon due to the original author not responding any more.
Projects
None yet
Development

No branches or pull requests

4 participants