Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-source-wordpress): Cannot read property of undefined error with polylang #19331

Merged
merged 1 commit into from
Nov 7, 2019
Merged

fix(gatsby-source-wordpress): Cannot read property of undefined error with polylang #19331

merged 1 commit into from
Nov 7, 2019

Conversation

maktouch
Copy link
Contributor

@maktouch maktouch commented Nov 7, 2019

Description

This patch makes a simple check before returning the id key, which sometimes fails because it's sometime null.

Published a forked package here: https://www.npmjs.com/package/@splitmedialabs/gatsby-source-wordpress for our own project, and it works =)

Related Issues

Fixes #19285

Previous PR #19329 was closed because my amateur mistakes (forgot to pull latest version, and used an already declared entity var)

@maktouch maktouch requested a review from a team as a code owner November 7, 2019 09:52
Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @maktouch!

@pieh pieh merged commit bd48b21 into gatsbyjs:master Nov 7, 2019
@gatsbot
Copy link

gatsbot bot commented Nov 7, 2019

Holy buckets, @maktouch — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-source-wordpress] Cannot read property of undefined error with polylang
2 participants